fixed: review changes
Project: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/commit/55a8d965 Tree: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/tree/55a8d965 Diff: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/diff/55a8d965 Branch: refs/heads/master Commit: 55a8d965fb4512df87cde2b3ec712a8809b773f6 Parents: 1e8f57b Author: Hitesh Gautam <gautam31.hit...@gmail.com> Authored: Tue Feb 20 10:08:41 2018 +0530 Committer: Hitesh Gautam <gautam31.hit...@gmail.com> Committed: Tue Feb 20 10:08:41 2018 +0530 ---------------------------------------------------------------------- .../apache/taverna/mobile/ui/workflow/WorkflowPresenter.java | 8 ++++---- .../mobile/ui/workflowdetail/WorkflowDetailPresenter.java | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/blob/55a8d965/app/src/main/java/org/apache/taverna/mobile/ui/workflow/WorkflowPresenter.java ---------------------------------------------------------------------- diff --git a/app/src/main/java/org/apache/taverna/mobile/ui/workflow/WorkflowPresenter.java b/app/src/main/java/org/apache/taverna/mobile/ui/workflow/WorkflowPresenter.java index f73c83f..0856f63 100644 --- a/app/src/main/java/org/apache/taverna/mobile/ui/workflow/WorkflowPresenter.java +++ b/app/src/main/java/org/apache/taverna/mobile/ui/workflow/WorkflowPresenter.java @@ -98,10 +98,10 @@ public class WorkflowPresenter extends BasePresenter<WorkflowMvpView> { .subscribeOn(Schedulers.io()) .subscribeWith(new DisposableObserver<String>() { @Override - public void onNext(String s) { - getMvpView().performSearch(s); - if (!TextUtils.isEmpty(s)) { - searchWorkflow(1, s); + public void onNext(String searchText) { + getMvpView().performSearch(searchText); + if (!TextUtils.isEmpty(searchText)) { + searchWorkflow(1, searchText); } } http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/blob/55a8d965/app/src/main/java/org/apache/taverna/mobile/ui/workflowdetail/WorkflowDetailPresenter.java ---------------------------------------------------------------------- diff --git a/app/src/main/java/org/apache/taverna/mobile/ui/workflowdetail/WorkflowDetailPresenter.java b/app/src/main/java/org/apache/taverna/mobile/ui/workflowdetail/WorkflowDetailPresenter.java index 2af95af..a19bec1 100644 --- a/app/src/main/java/org/apache/taverna/mobile/ui/workflowdetail/WorkflowDetailPresenter.java +++ b/app/src/main/java/org/apache/taverna/mobile/ui/workflowdetail/WorkflowDetailPresenter.java @@ -168,8 +168,8 @@ public class WorkflowDetailPresenter extends BasePresenter<WorkflowDetailMvpView .subscribeOn(Schedulers.io()) .subscribeWith(new DisposableObserver<Boolean>() { @Override - public void onNext(Boolean b) { - getMvpView().getFavouriteIcon(b); + public void onNext(Boolean favoriteStatus) { + getMvpView().getFavouriteIcon(favoriteStatus); } @Override
