Repository: incubator-taverna-mobile
Updated Branches:
  refs/heads/master b88b625bb -> 109601623


Improvements in Login Screen UI


Project: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/commit/10960162
Tree: 
http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/tree/10960162
Diff: 
http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/diff/10960162

Branch: refs/heads/master
Commit: 10960162391b3ca9f1422f591622b11040a3ca99
Parents: b88b625
Author: Hitesh Gautam <gautam31.hit...@gmail.com>
Authored: Sat Mar 10 01:03:54 2018 +0530
Committer: Hitesh Gautam <gautam31.hit...@gmail.com>
Committed: Sat Mar 10 12:59:37 2018 +0530

----------------------------------------------------------------------
 app/src/main/res/drawable/login_button.xml | 24 ++++++++++++++++++++++++
 app/src/main/res/layout/fragment_login.xml | 15 +++++++++------
 app/src/main/res/values/dimens.xml         | 12 +++++++++---
 3 files changed, 42 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/blob/10960162/app/src/main/res/drawable/login_button.xml
----------------------------------------------------------------------
diff --git a/app/src/main/res/drawable/login_button.xml 
b/app/src/main/res/drawable/login_button.xml
new file mode 100644
index 0000000..1f1b999
--- /dev/null
+++ b/app/src/main/res/drawable/login_button.xml
@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+   Licensed to the Apache Software Foundation (ASF) under one or more
+   contributor license agreements.  See the NOTICE file distributed with
+   this work for additional information regarding copyright ownership.
+   The ASF licenses this file to You under the Apache License, Version 2.0
+   (the "License"); you may not use this file except in compliance with
+   the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+-->
+
+<shape xmlns:android="http://schemas.android.com/apk/res/android";
+    android:shape="rectangle"
+    android:padding="10dp">
+    <solid android:color="@color/colorPrimaryDark"/>
+    <corners android:radius="@dimen/login_button_radius"/>
+</shape>
\ No newline at end of file

http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/blob/10960162/app/src/main/res/layout/fragment_login.xml
----------------------------------------------------------------------
diff --git a/app/src/main/res/layout/fragment_login.xml 
b/app/src/main/res/layout/fragment_login.xml
index c3bb1a0..6d853fe 100644
--- a/app/src/main/res/layout/fragment_login.xml
+++ b/app/src/main/res/layout/fragment_login.xml
@@ -32,8 +32,8 @@
 
         <ImageView
             android:id="@+id/logo"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
+            android:layout_width="@dimen/logo_width"
+            android:layout_height="@dimen/logo_height"
             android:layout_alignParentTop="true"
             android:layout_centerHorizontal="true"
             android:contentDescription="@string/brand"
@@ -113,14 +113,16 @@
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:checked="true"
+                android:layout_gravity="center"
+                android:layout_marginTop="@dimen/checkbox_margin_top"
                 android:text="@string/keeplogin"/>
 
             <android.support.v7.widget.AppCompatButton
                 android:id="@+id/bLogin"
                 android:layout_width="match_parent"
-                android:layout_height="wrap_content"
+                android:layout_height="@dimen/login_height"
                 android:textColor="@color/white"
-                android:background="@color/colorPrimary"
+                android:background="@drawable/login_button"
                 android:layout_marginBottom="@dimen/loginButton_marginBottom"
                 android:layout_marginTop="@dimen/loginButton_marginTop"
                 android:contentDescription="@string/login_button_description"
@@ -129,11 +131,12 @@
             <android.support.v7.widget.AppCompatButton
                 style="@style/Widget.AppCompat.Button.Borderless"
                 android:id="@+id/bRegister"
-                android:layout_height="wrap_content"
+                android:layout_height="@dimen/signup_height"
                 android:layout_width="match_parent"
+                android:layout_marginTop="@dimen/signup_margin_top"
                 android:text="@string/create_an_account"
                 
android:textAppearance="@style/Base.TextAppearance.AppCompat.Small"
-                android:textColor="@color/primary"/>
+                android:textColor="@color/colorPrimaryDark"/>
 
         </LinearLayout>
 

http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/blob/10960162/app/src/main/res/values/dimens.xml
----------------------------------------------------------------------
diff --git a/app/src/main/res/values/dimens.xml 
b/app/src/main/res/values/dimens.xml
index 05a3adf..c0a3874 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -74,12 +74,18 @@ limitations under the License.
     <dimen name="login_layout_marginTop">20dp</dimen>
     <dimen name="login_info_padding">10dp</dimen>
     <dimen name="login_text_size">20sp</dimen>
-    <dimen name="input_layout_email_margin">10dp</dimen>
+    <dimen name="input_layout_email_margin">20dp</dimen>
     <dimen name="loginButton_marginBottom">8dp</dimen>
-    <dimen name="loginButton_marginTop">30dp</dimen>
+    <dimen name="loginButton_marginTop">10dp</dimen>
     <dimen name="appName_text_margin">12dp</dimen>
     <dimen name="title_text_size">40sp</dimen>
     <dimen name="logo_margin_top">40dp</dimen>
-
+    <dimen name="signup_margin_top">2dp</dimen>
+    <dimen name="signup_height">50dp</dimen>
+    <dimen name="login_height">50dp</dimen>
+    <dimen name="checkbox_margin_top">30dp</dimen>
+    <dimen name="logo_height">70dp</dimen>
+    <dimen name="logo_width">70dp</dimen>
+    <dimen name="login_button_radius">80dp</dimen>
 
 </resources>

Reply via email to