(texera) branch main updated: test(workflow-core): add unit test coverage for FinalizePort and FinalizeExecutor markers (#4792)

[yiconghuang]

This is an automated email from the ASF dual-hosted git repository.

Yicong-Huang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/texera.git


The following commit(s) were added to refs/heads/main by this push:
     new 5ecf746ff1 test(workflow-core): add unit test coverage for 
FinalizePort and FinalizeExecutor markers (#4792)
5ecf746ff1 is described below

commit 5ecf746ff12c84431991bd314eda25bd8d38ae14
Author: Xinyuan Lin <xinyu...@uci.edu>
AuthorDate: Sun May 3 09:06:18 2026 -0700

    test(workflow-core): add unit test coverage for FinalizePort and 
FinalizeExecutor markers (#4792)
    
    ### What changes were proposed in this PR?
    
    Add `InternalMarkerSpec` covering the `FinalizePort` and
    `FinalizeExecutor` payloads used to signal finalization within a
    `TupleLike` stream:
    
    - `FinalizePort` carries the configured `portId` and `input` direction
    - Both markers are `TupleLike` with empty `getFields` and zero
    `inMemSize`
    - `FinalizePort` respects case-class equality on its constructor
    arguments
    - Two `FinalizeExecutor` instances are equal (no-field case class)
    - The two markers are distinguishable via pattern matching (the test
    classifies a heterogeneous `List[TupleLike]` and asserts the dispatch
    labels), exercising the actual call-site idiom rather than just `==`
    
    ### Any related issues, documentation, discussions?
    
    Closes #4791
    
    ### How was this PR tested?
    
    `sbt "WorkflowCore/testOnly
    org.apache.texera.amber.core.tuple.InternalMarkerSpec"` — 6/6 tests
    pass.
    
    ### Was this PR authored or co-authored using generative AI tooling?
    
    Generated-by: Claude Code (Claude Opus 4.7)
    
    ---------
    
    Co-authored-by: Claude Opus 4.7 (1M context) <nore...@anthropic.com>
---
 .../amber/core/tuple/InternalMarkerSpec.scala      | 76 ++++++++++++++++++++++
 1 file changed, 76 insertions(+)

diff --git 
a/common/workflow-core/src/test/scala/org/apache/texera/amber/core/tuple/InternalMarkerSpec.scala
 
b/common/workflow-core/src/test/scala/org/apache/texera/amber/core/tuple/InternalMarkerSpec.scala
new file mode 100644
index 0000000000..2b51ec3f0b
--- /dev/null
+++ 
b/common/workflow-core/src/test/scala/org/apache/texera/amber/core/tuple/InternalMarkerSpec.scala
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.texera.amber.core.tuple
+
+import org.apache.texera.amber.core.workflow.PortIdentity
+import org.scalatest.flatspec.AnyFlatSpec
+
+class InternalMarkerSpec extends AnyFlatSpec {
+
+  "FinalizePort" should "carry the configured portId and direction" in {
+    val marker = FinalizePort(PortIdentity(3), input = false)
+    assert(marker.portId == PortIdentity(3))
+    assert(!marker.input)
+  }
+
+  it should "be a TupleLike with empty getFields and zero inMemSize" in {
+    val marker = FinalizePort(PortIdentity(0), input = true)
+    assert(marker.isInstanceOf[TupleLike])
+    assert(marker.getFields.isEmpty)
+    assert(marker.inMemSize == 0L)
+  }
+
+  it should "respect case-class equality on the constructor arguments" in {
+    assert(
+      FinalizePort(PortIdentity(0), input = true) == 
FinalizePort(PortIdentity(0), input = true)
+    )
+    assert(
+      FinalizePort(PortIdentity(0), input = true) != 
FinalizePort(PortIdentity(0), input = false)
+    )
+    assert(
+      FinalizePort(PortIdentity(0), input = true) != 
FinalizePort(PortIdentity(1), input = true)
+    )
+  }
+
+  "FinalizeExecutor" should "be a TupleLike with empty getFields and zero 
inMemSize" in {
+    val marker = FinalizeExecutor()
+    assert(marker.isInstanceOf[TupleLike])
+    assert(marker.getFields.isEmpty)
+    assert(marker.inMemSize == 0L)
+  }
+
+  it should "be equal to another FinalizeExecutor instance (no-field case 
class)" in {
+    assert(FinalizeExecutor() == FinalizeExecutor())
+  }
+
+  "InternalMarker" should "be distinguishable via pattern matching" in {
+    val markers: List[TupleLike] = List(
+      FinalizePort(PortIdentity(0), input = true),
+      FinalizeExecutor()
+    )
+    val classified = markers.map {
+      case FinalizePort(_, _)    => "port"
+      case FinalizeExecutor()    => "executor"
+      case other: InternalMarker => s"other-marker:$other"
+      case other                 => s"non-marker:$other"
+    }
+    assert(classified == List("port", "executor"))
+  }
+}