The GitHub Actions job "License Binary Checker" on texera.git/main has failed. Run started by GitHub user bobbai00 (triggered by bobbai00).
Head commit for run: b9bbf0db799c0867594e20181dd5a7a6bee38826 / Matthew B. <[email protected]> fix: admin-adjustable max columns with a clear overflow message (#4669) <!-- Thanks for sending a pull request (PR)! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: [Contributing to Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) 2. Ensure you have added or run the appropriate tests for your PR 3. If the PR is work in progress, mark it a draft on GitHub. 4. Please write your PR title to summarize what this PR proposes, we are following Conventional Commits style for PR titles as well. 5. Be sure to keep the PR description updated to reflect all changes. --> ### What changes were proposed in this PR? <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes. Here are some tips for you: 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, you can clarify why it is a bug. 3. If it is a refactoring, clarify what has been changed. 3. It would be helpful to include a before-and-after comparison using screenshots or GIFs. 4. Please consider writing useful notes for better and faster reviews. --> - **Admin-adjustable max columns.** Adds `csv_parser_max_columns` to Admin → Settings → Result Panel. The CSV scan operator reads this from `site_settings` at runtime. - **Readable overflow error.** When a CSV row exceeds the limit, the operator now throws `RuntimeException("Max columns of N exceeded.")` Instead of letting Univocity's raw stack trace through. Detection looks at the cause (`ArrayIndexOutOfBoundsException`) and parses the index from both the Java 8 and Java 9+ message formats — needed because Univocity's own hint string is silently dropped on Java 9+. - **Refactor.** Extracts the repeated "read int/long from `site_settings` with fallback" pattern into `common/dao/SiteSettings`, replacing inline jOOQ in `CSVScanSourceOpExec` and `DatasetResource`. ### Any related issues, documentation, discussions? <!-- Please use this section to link other resources if not mentioned already. 1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves #1234` or `Closes #1234`. If it is only related, simply mention the issue number. 2. If there is design documentation, please add the link. 3. If there is a discussion in the mailing list, please add the link. --> closes #4589 Related #3825 ### How was this PR tested? <!-- If tests were added, say they were added here. Or simply mention that if the PR is tested with existing test cases. Make sure to include/update test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> - New `CSVScanSourceOpExecSpec`: happy path, end-of-input, overflow translation against a real parser, and `isColumnOverflow` cases for both AIOOBE message formats. - Expanded `admin-settings.component.spec.ts` for load/save/reset of the max columns setting. - `sbt Test/compile` clean across DAO, ConfigService, WorkflowOperator, FileService. Frontend specs need Node ≥ 20.19 to run. - Manual: lowered the limit, ran a workflow on a CSV that exceeded it, confirmed the result panel shows `Max columns of N exceeded.` ### Was this PR authored or co-authored using generative AI tooling? <!-- If generative AI tooling has been used in the process of authoring this PR, please include the phrase: 'Generated-by: ' followed by the name of the tool and its version. If no, write 'No'. Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details. --> Co-authored with: Claude Opus 4.7 --------- Co-authored-by: Chen Li <[email protected]> Co-authored-by: Xinyuan Lin <[email protected]> Report URL: https://github.com/apache/texera/actions/runs/25493166640 With regards, GitHub Actions via GitBox
