The GitHub Actions job "Required Checks" on texera.git/chore/monaco-lsp-v10 has failed. Run started by GitHub user aglinxinyuan (triggered by aglinxinyuan).
Head commit for run: 51b4fe55461ee41b3854b7191b7e6c86d0425c0f / Xinyuan Lin <[email protected]> chore(frontend): address Copilot review on code-editor.component Three Copilot review comments on #4997 — all valid, addressed in this commit. (A fourth comment about an unused `const fs = require("fs")` in custom-webpack.config.js was already resolved by de4d47b7b2 when the license-webpack-plugin patch block was deleted as dead code.) * Timeout scope: previously `LANGUAGE_SERVER_CONNECTION_TIMEOUT_MS` wrapped the entire `startEditor()` promise, including `ensureVscodeApiStarted()` and `EditorApp.start()`. On first load codingame v25 init can easily exceed 1s, so the timeout could fire before the editor mount completes and the rxjs `catchError` fallback would emit `undefined` (filtered out → MonacoBinding/actions/debugger never attach). Pulled the timeout out of the rxjs pipeline and into a `Promise.race` around `languageClientWrapper.start()` only; the editor mount is now always awaited to completion. Drops the unused `timeout` / `catchError` / `of` rxjs imports. * Sticky rejection cache: `apiWrapperStartPromise` is shared across every CodeEditorComponent instance. If wrapper / extension activation ever rejected, the rejected promise would be returned forever and no subsequent open could retry. Wrapped the IIFE body in try/catch and reset the cache before re-throwing. * Awareness-driven CSS injection: `getCoeditorCursorStyles` interpolates `coeditor.clientId` and `coeditor.color` (both writeable by any peer via yjs awareness) into a `<style>` tag passed through `bypassSecurityTrustHtml`. Anything that breaks out of the tag would land in the page as raw HTML. Added two tight allow-list regexes (digits-only id, hex / `rgb(a)` / `hsl(a)` colour) and bail out to an empty stylesheet if either fails. Build + license + tests verified locally: yarn build:ci EXIT 0 (worker chunks byte-identical) check_binary_deps.py OK: 113 npm packages match yarn test 63 / 269 (parity) Report URL: https://github.com/apache/texera/actions/runs/25596937279 With regards, GitHub Actions via GitBox
