This is an automated email from the ASF dual-hosted git repository. github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-5679-1a65a3168c5ffbd171e8ed0d64dec495e45c1b24 in repository https://gitbox.apache.org/repos/asf/texera.git
commit 6becb8596df32058f69473c39f4a9028f149954e Author: Kyle Yin Xu <[email protected]> AuthorDate: Sat Jun 13 11:00:43 2026 -0700 test(workflow-operator): add ImageUtilitySpec for encodeImageToHTML (#5679) <!-- Thanks for sending a pull request (PR)! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: [Contributing to Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) 2. Ensure you have added or run the appropriate tests for your PR 3. If the PR is work in progress, mark it a draft on GitHub. 4. Please write your PR title to summarize what this PR proposes, we are following Conventional Commits style for PR titles as well. 5. Be sure to keep the PR description updated to reflect all changes. --> ### What changes were proposed in this PR? Pin the Python snippet emitted by ImageUtility.encodeImageToHTML() — the helper that visualization operators splice into generated UDF code to base64-encode binary image data into an <img> tag. Any drift in the f-string template or the error fallback would silently break image-rendering operators (e.g. Word Cloud). No production-code changes. Negative cases are covered implicitly: removing any pinned substring fails the corresponding assertion. | Spec | Source Class | Tests | | --- | --- | --- | | ImageUtilitySpec | ImageUtility | 8 | Spec file name follows the `<srcClassName>Spec.scala` one-to-one convention. **Behavior pinned** | Surface | Contract | | :--- | :--- | | `encodeImageToHTML` | returns a non-empty `String` | | Snippet imports base64 | substring `import base64` appears | | Snippet calls `base64.b64encode(binary_image_data)` | substring appears verbatim | | Snippet decodes to UTF-8 | substring `.decode("utf-8")` appears | | Snippet emits an `<img>` tag with `data:image;base64,...` | substring `data:image;base64,{encoded_image_str}` appears (verifies the f-string template) | | Snippet handles binary-decode failure via try/except | substrings `except Exception` and `Binary input is not valid` both appear | | Snippet contains a top-level `html =` assignment | substring `html = f` appears so downstream code can reference `html` | | Determinism | two calls return the exact same string | The harness pins via `contains` on canonical substrings — resilient to incidental whitespace changes from `stripMargin` while still catching real template drift. ### Any related issues, documentation, discussions? <!-- Please use this section to link other resources if not mentioned already. 1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves #1234` or `Closes #1234`. If it is only related, simply mention the issue number. 2. If there is design documentation, please add the link. 3. If there is a discussion in the mailing list, please add the link. --> Closes #5665 ### How was this PR tested? <!-- If tests were added, say they were added here. Or simply mention that if the PR is tested with existing test cases. Make sure to include/update test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> Unit tests were added here, tested through local verification: - ```sbt "WorkflowOperator/testOnly org.apache.texera.amber.operator.visualization.ImageUtilitySpec"``` - All 8 tests passed - ```sbt scalafmtCheckAll``` -- clean - ```sbt scalafixAll --check``` No lint errors ### Was this PR authored or co-authored using generative AI tooling? <!-- If generative AI tooling has been used in the process of authoring this PR, please include the phrase: 'Generated-by: ' followed by the name of the tool and its version. If no, write 'No'. Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details. --> Generated-by: Composer 2.5 Fast --- .../operator/visualization/ImageUtilitySpec.scala | 65 ++++++++++++++++++++++ 1 file changed, 65 insertions(+) diff --git a/common/workflow-operator/src/test/scala/org/apache/texera/amber/operator/visualization/ImageUtilitySpec.scala b/common/workflow-operator/src/test/scala/org/apache/texera/amber/operator/visualization/ImageUtilitySpec.scala new file mode 100644 index 0000000000..65874b72f8 --- /dev/null +++ b/common/workflow-operator/src/test/scala/org/apache/texera/amber/operator/visualization/ImageUtilitySpec.scala @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.texera.amber.operator.visualization + +import org.scalatest.flatspec.AnyFlatSpec + +class ImageUtilitySpec extends AnyFlatSpec { + + "ImageUtility.encodeImageToHTML" should "return a non-empty Python snippet" in { + assert(ImageUtility.encodeImageToHTML().nonEmpty) + } + + it should "import base64 for encoding" in { + assert(ImageUtility.encodeImageToHTML().contains("import base64")) + } + + it should "base64-encode binary_image_data" in { + assert( + ImageUtility.encodeImageToHTML().contains("base64.b64encode(binary_image_data)") + ) + } + + it should "decode encoded bytes as UTF-8" in { + assert(ImageUtility.encodeImageToHTML().contains(""".decode("utf-8")""")) + } + + it should "emit a data-URI img tag via an f-string template" in { + assert( + ImageUtility.encodeImageToHTML().contains("data:image;base64,{encoded_image_str}") + ) + } + + it should "handle binary decode failure with try/except and a render_error fallback" in { + val snippet = ImageUtility.encodeImageToHTML() + assert(snippet.contains("except Exception")) + assert(snippet.contains("Binary input is not valid")) + } + + it should "assign the img tag to html for downstream yield sites" in { + assert(ImageUtility.encodeImageToHTML().contains("html = f")) + } + + it should "be deterministic across repeated calls" in { + val first = ImageUtility.encodeImageToHTML() + val second = ImageUtility.encodeImageToHTML() + assert(first == second) + } +}
