The GitHub Actions job "Required Checks" on texera.git/main has failed. Run started by GitHub user github-merge-queue[bot] (triggered by github-merge-queue[bot]).
Head commit for run: ed22158534c1ae503fea9b4338a03862b5231c97 / Matthew B. <[email protected]> refactor(config): unify default-data-transfer-batch-size into one config key (#5545) ### What changes were proposed in this PR? The default data-transfer batch size was controlled by **two** separate config keys, each with its own env var, both defaulting to `400`: - `network-buffering.default-data-transfer-batch-size` (`NETWORK_BUFFERING_DEFAULT_DATA_TRANSFER_BATCH_SIZE`), read by the backend (`ApplicationConfig.defaultDataTransferBatchSize`). - `gui.workflow-workspace.default-data-transfer-batch-size` (`GUI_WORKFLOW_WORKSPACE_DEFAULT_DATA_TRANSFER_BATCH_SIZE`), read by `GuiConfig` and sent to the frontend via `ConfigResource`. Having two keys for one value meant an operator could set one env var and forget the other, leaving the backend and GUI out of sync. This PR makes the `network-buffering` key the single source of truth: - `ConfigResource` now surfaces `ApplicationConfig.defaultDataTransferBatchSize` directly. - Removed the duplicate `guiWorkflowWorkspaceDefaultDataTransferBatchSize` field from `GuiConfig`. - Removed the duplicate key (and its env override) from `gui.conf`. The frontend is unchanged: the JSON field name (`defaultDataTransferBatchSize`) it consumes stays the same. ### Any related issues, documentation, discussions? Closes #5544 ### How was this PR tested? - `sbt Config/compile ConfigService/compile` both succeed. - Repo-wide grep confirms no remaining references to the old key or `GUI_WORKFLOW_WORKSPACE_DEFAULT_DATA_TRANSFER_BATCH_SIZE` (outside generated `dist/` artifacts). - The backend reader of the canonical key is untouched, so existing tests (e.g. `NetworkOutputBufferSpec`) are unaffected. - Also tested that the application performs as normal on all services (e.g., running workflows, uploading data, creating workflows, etc..) ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) Report URL: https://github.com/apache/texera/actions/runs/27921696289 With regards, GitHub Actions via GitBox
