The GitHub Actions job "Required Checks" on texera.git/gh-readonly-queue/main/pr-6493-49f9e2c414b116bf328bdb9154cc97dc4d1e7e9e has failed. Run started by GitHub user xuang7 (triggered by xuang7).
Head commit for run: 133b9122fa72ba51a291a863beaa40a6b212e14b / Ranjani Veena Belavadi <[email protected]> refactor(frontend): extract dataset settings into Settings tab (#6493) ### What changes were proposed in this PR? Extracted the dataset settings/admin functionality on the dataset detail page into a dedicated Settings tab, alongside existing content (now under a Data Card tab). Part of the parent tab-based layout refactor (#6394). Visibility toggle, downloadable toggle, and description editor moved from the header's gear-icon popover into the new Settings tab. The gear icon and popover are removed. Added dataset rename (input + Save), calling the existing `DatasetService.updateDatasetName()` and reusing the name-sanitization logic already used in the dataset version creator. Added dataset delete, calling the existing `DatasetService.deleteDatasets()` with the same `nz-popconfirm` confirmation pattern used on the Datasets list page; redirects to the list on success. Before: settings were scattered, visibility/downloadable behind a gear icon, description editable only in the header, rename/delete only reachable from the Datasets list page. <img width="1915" height="1015" alt="settings_tab_recording_old" src="https://github.com/user-attachments/assets/3d29d0f3-0fbb-4caa-8c8f-ee0348df0ab1"; /> After: all dataset settings are consolidated in one Settings tab on the detail page itself. <img width="1915" height="1018" alt="settings_tab_recording" src="https://github.com/user-attachments/assets/348effd0-e8fd-4583-baff-118af9c83fee"; /> ### Any related issues, documentation, discussions? Closes #6395 ### How was this PR tested? Added 7 unit tests to `dataset-detail.component.spec.ts` covering the two new methods (`onSaveDatasetName`, `onDeleteDataset`): name sanitization, success/error paths, and navigation on delete. The relocated toggles/description editor already had existing test coverage prior to this PR, so no new tests were needed there. 66/66 tests passing (59 pre-existing, 7 new). Also manually tested on UI, since the relocated functionality itself is unchanged behavior: - Renamed a dataset; confirmed persistence and correct sanitization of invalid characters. - Edited and saved the description; confirmed it reflects on the Datasets list page. - Toggled visibility and downloadable; confirmed state persists and header badges update accordingly. - Deleted a test dataset; confirmed confirmation prompt, successful deletion, and redirect to the Datasets list with the dataset removed. - Confirmed the Data Card tab (file browser, version history, uploads) is unaffected. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 4.8) --------- Signed-off-by: Ranjani Veena Belavadi <[email protected]> Co-authored-by: Xuan Gu <[email protected]> Report URL: https://github.com/apache/texera/actions/runs/30303658397 With regards, GitHub Actions via GitBox
