The GitHub Actions job "Required Checks" on texera.git/test-ws-serde has 
succeeded.
Run started by GitHub user aglinxinyuan (triggered by aglinxinyuan).

Head commit for run:
7b7cad7736845bf6ec6b367cfd9f45d38b6696d6 / Xinyuan Lin <[email protected]>
test(amber): scope the websocket registry assertions to the backend

Addresses review feedback on the wording and one brittle assertion:

- The @JsonSubTypes assertions validate the BACKEND registry, not "what the
  Angular client sends/resolves". The frontend type maps are supersets: the
  request map also declares ResultExportRequest (an HTTP model on the
  backend, not a websocket subtype), and the event map keys on the
  outbound-only events plus OperatorCurrentTuplesUpdateEvent and
  RecoveryStartedEvent, which have no backend producer at all. Retitled
  both tests and reworded the two comments accordingly.
- The unknown-type-id test now uses a discriminator that exists nowhere on
  either side, so it cannot be misread as a claim about a real type. The
  ResultExportRequest rejection moved to its own named test that documents
  the frontend/backend divergence explicitly.
- Loosened the missing-type-id message assertion to just the property name;
  InvalidTypeIdException is the actual contract and Jackson's exact wording
  is version-specific.

Report URL: https://github.com/apache/texera/actions/runs/30512048098

With regards,
GitHub Actions via GitBox

Reply via email to