The GitHub Actions job "Required Checks" on 
texera.git/gh-readonly-queue/main/pr-7214-436b37e9b62e6be2ef8ea911ec30387dd7e80415
 has failed.
Run started by GitHub user xuang7 (triggered by xuang7).

Head commit for run:
946fcf322b74dfc7a9b827ad4579aef118a4b4ff / Prateek Ganigi 
<[email protected]>
fix(workflow-operator): add missing defaultValue to HF temperature property 
(#7214)

### What changes were proposed in this PR?

The temperature field's default (0.7) and valid range weren't advertised
in the operator's JSON schema. It can't be done with
@JsonProperty(defaultValue = "0.7"): the schema generator (mbknor
jackson-jsonSchema) parses a numeric field's defaultValue with .toInt,
so a floating-point value throws NumberFormatException and breaks
operator-metadata generation, which is why "0.7" was the only float
defaultValue in the repo. Instead this uses @JsonSchemaInject (the
pattern already used for Double fields in
RadarChartOpDesc/ScatterplotOpDesc), injecting { "minimum": 0.0,
"maximum": 2.0, "default": 0.7 } to match the field's runtime clamp and
description.

### Any related issues, documentation, discussions?
Closes #7201.

### How was this PR tested?
sbt "WorkflowOperator/testOnly
org.apache.texera.amber.operator.huggingFace.*
org.apache.texera.amber.operator.metadata.*", the Hugging Face suite
plus the operator-metadata specs pass (147 tests), including
PythonCodeRawInvalidTextSpec (py-compiles every operator's generated
Python) and the schema-generation path this change touches. scalafmt
clean.

Schema-metadata-only change: it doesn't affect the generated Python or
any runtime behavior, so no new test was added.

### Was this PR authored or co-authored using generative AI tooling?
No, this PR wasn't authored or co-authored using generative AI tooling.

Report URL: https://github.com/apache/texera/actions/runs/30772943888

With regards,
GitHub Actions via GitBox

Reply via email to