The GitHub Actions job "Required Checks" on texera.git/gh-readonly-queue/main/pr-7256-a96bf3e70c0e9d5bf72402637633b36e99049a25 has succeeded. Run started by GitHub user xuang7 (triggered by xuang7).
Head commit for run: 5e41efae2650c3e70d7490b15bb1fdf9b1983568 / Kary Zheng <[email protected]> feat(time-series): declare Plot Type's two values as a schema enum (#7256) ### What changes were proposed in this PR? `plotType` — the **Plot Type** field — was a plain string whose two legal values existed only in its description, so the form rendered a free-text box. It now declares them as a schema `enum`, which ngx-formly renders as a dropdown; `ECDFPlotOpDesc` already declares its string modes this way, so no frontend change is involved. The property's declared name stays `line`, since that is what saved workflows carry, and the generator's fallback is untouched. ### Why are the changes needed? The value is matched exactly — `if (plotType == "area") "px.area" else "px.line"` — so anything else draws a line chart and reports nothing. Generating the module on `main`: | Plot Type | Generated call | | --- | --- | | `area` | `px.area(table, ...)` | | `Area` — capitalised | `px.line(table, ...)` | | `aera` — one letter off | `px.line(table, ...)` | `Area` is the sharp case: likely to be typed, and the result is indistinguishable from having asked for a line chart. ### Any related issues, documentation, discussions? Closes #7251 ### How was this PR tested? `WorkflowOperator/compile`, `scalafmtCheckAll`, and `TimeSeriesOpDescSpec` (13 tests). That suite pins the fallback by setting `plotType = "bar"` directly and asserting `px.line`; it bypasses the form, so it still passes. ### Does this PR introduce any user-facing change? Yes. Plot Type becomes a dropdown of `line` and `area`. Saved workflows carrying either are unaffected; one carrying anything else was already drawn as a line and still is. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5) --------- Co-authored-by: Claude Opus 5 (1M context) <[email protected]> Co-authored-by: Xuan Gu <[email protected]> Report URL: https://github.com/apache/texera/actions/runs/31211082136 With regards, GitHub Actions via GitBox
