The GitHub Actions job "Required Checks" on 
texera.git/feat/7751-require-warehouse has failed.
Run started by GitHub user mengw15 (triggered by mengw15).

Head commit for run:
2727aa5cc1b3f6269c658ed69a3ebbe7cd837225 / mengw15 
<[email protected]>
feat: require a warehouse for every execution while the feature is enabled

With per-user warehouses enabled, an execution carrying no warehouseId
silently wrote into the shared default warehouse: resolveWarehouseName
mapped None to None whenever the flag was on. So "a run writes into the
user's own warehouse" was a UI convention rather than a system property,
and one path already violated it -- SyncExecutionResource hardcoded
warehouseId = None, so on a deployment with the feature on every
agent-driven execution landed in the shared warehouse.

Make the pick required the same way a computing unit is, and carry it
along the same path the computing unit already travels:

  - WorkflowService.resolveWarehouseName fails instead of falling back
    when the flag is on and nothing was picked. The websocket path needs
    nothing more -- the UI always sends its pick.
  - SyncExecutionRequest gains warehouseId and the endpoint forwards it
    instead of hardcoding None.
  - agent-service threads warehouseId through ExecutionConfig and the
    delegate config into that request body, mirroring computingUnitId.
  - The frontend sends the warehouse the user picked when creating an
    agent, right where it already sends the selected computing unit.

Flag-off behaviour is unchanged: an explicit pick is still refused loudly
(#6930) and no pick still means the shared warehouse.

Part of #6870. Closes #7751.

Report URL: https://github.com/apache/texera/actions/runs/32108219173

With regards,
GitHub Actions via GitBox

Reply via email to