The GitHub Actions job "Required Checks" on 
texera.git/chore/7913-admin-settings has failed.
Run started by GitHub user mengw15 (triggered by mengw15).

Head commit for run:
e7b2f480a8389ad51e9a7ba3f019018898dee276 / mengw15 
<[email protected]>
test(frontend): cover the admin settings uploads and save guards

Takes the last uncovered lines and half-taken branches of 
AdminSettingsComponent:
the file-upload reader's remaining arms, the favicon leg of saveLogos, the two
computed part-size getters, the settings-not-loaded guards, and the CSV reset
error handler. Template and branches now sit at 100%.

The upload tests reuse the FileReader double the spec already had, lifted into a
helper so the logo, favicon and non-string-result arms share it; a result that 
is
not a string takes the other side of the handler's type guard.

Two notes where the issue and the code disagree, and the tests follow the code:
onFileChange routes mini_logo to miniLogoData and the remaining type (favicon) 
to
faviconData, not what the issue describes; and the lines the issue attributes to
resetTabs are actually the partsAtMax and requiredMinPartSizeMiB getters below 
it.

Report URL: https://github.com/apache/texera/actions/runs/32818010327

With regards,
GitHub Actions via GitBox

Reply via email to