The GitHub Actions job "Required Checks" on texera.git/gh-readonly-queue/main/pr-7451-8cccfd8b438278ce97b8b73327f7dd81d37e1d46 has failed. Run started by GitHub user aglinxinyuan (triggered by aglinxinyuan).
Head commit for run: 6c7f902bda9cd250960f74a1339dc64f9a77c797 / Xinyuan Lin <[email protected]> chore(amber): remove the unused ElidableStatement (#7451) ### What changes were proposed in this PR? Deletes `ElidableStatement` and its spec. Pure deletion, no behaviour change: **−175 lines**. | Symbol | Location | Lines | | --- | --- | ---: | | `ElidableStatement` | `amber/.../engine/common/ElidableStatement.scala` | 34 | | `ElidableStatementSpec` | `amber/.../engine/common/ElidableStatementSpec.scala` | 141 | The object wraps statements in `scala.annotation.elidable` so they can be compiled out below the `-Xelide-below` threshold. **It has no caller anywhere in the repo** — that alone is why it goes. It picked up unit tests during the 2026 coverage work, which is why it currently looks live; the spec covers this object and nothing else, so it goes with it. > **Correction to the original description — thanks @Yicong-Huang.** The first version of this description (and of #7448) claimed `-Xelide-below` was configured nowhere. That is wrong. Sixteen `build.sbt` files pin it at `WARNING` (900), and all four wrappers — `FINEST` (300), `FINER` (400), `FINE` (500), `INFO` (800) — sit below it, so the elision was live and every call site was compiled out. That is exactly what the deleted spec pinned: `assert(counter == 0)` after `ElidableStatement.info { counter += 1 }` only holds under elision. With zero call sites, nothing was being elided, so the outcome is unchanged. `-Xelide-below WARNING` itself is untouched here. After this PR no `@elidable` annotation is left in the tree, so that flag switches nothing — worth removing, but it sits in sixteen build files, so it belongs in its own PR: #7709, tracked by #7706. That PR is **stacked on this one** and needs a rebase once this merges. ### Any related issues, documentation, discussions? Closes #7448 ### How was this PR tested? Existing tests only — this PR adds none, since it removes code and the spec that covered it. Locally, from the repo root with Java 17: - `sbt "WorkflowExecutionService/Test/compile"` — success. Verification, re-runnable by a reviewer: ``` git grep -in elidable # nothing at this branch's head git grep -n Xelide -- '*.sbt' # 16 modules, all WARNING — the switch, left in place ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5) Report URL: https://github.com/apache/texera/actions/runs/33234944462 With regards, GitHub Actions via GitBox
