The GitHub Actions job "Required Checks" on 
texera.git/fix/dataset-version-clear has succeeded.
Run started by GitHub user Yicong-Huang (triggered by Yicong-Huang).

Head commit for run:
af82e757a749234d57a09583aa3ef116d4709ada / Tanishq Gandhi 
<[email protected]>
fix(frontend): remove the clear button from the dataset version picker

The version dropdown on a dataset's detail page carried nzAllowClear, so
clicking the x emitted null into onVersionSelected(version: DatasetVersion),
which read this.selectedVersion.dvid and threw an uncaught TypeError. The page
was left half-cleared: the main pane said "No version is selected" while the
header still showed the cleared version's file path and the file tree still
listed its files.

Clearing the selection means nothing on a page whose entire content is one
version, so the button goes away. onVersionSelected also takes an optional
version now and skips the fetch without a dvid, so an empty selection cannot
throw even if the control pushes one. This mirrors the model detail page.

Closes #8342.

Report URL: https://github.com/apache/texera/actions/runs/33670473049

With regards,
GitHub Actions via GitBox

Reply via email to