The GitHub Actions job "Backport Approval Check" on 
texera.git/ci/8084-backport-manager-approval-gate has succeeded.
Run started by GitHub user mengw15 (triggered by mengw15).

Head commit for run:
1273f493e3c77a21550bf4a05356c37d4a663ab6 / mengw15 
<[email protected]>
ci: read the approvals config from the base, and finish the mirrored claim

Review findings on the previous head, verified before fixing.

Read release-branches.yml from the base commit rather than the PR head.
The head can be arbitrarily old, and neither the config nor its parser
existed before #6941, so a PR branched before that fails the `run:` step
with a file-not-found under `bash -eo pipefail` — a red required check
its author cannot clear by approving or unlabeling. 37 of the open pull
requests into main are in that state. Reading the base also puts this
back in agreement with the other two consumers: backport-auto-label.yml
pins `base.sha`, and Direct Backport Push reads main. The trade-off, a PR
editing the config being judged by the pre-edit copy, costs nothing here:
those are `ci:`-typed and carry no `release/*` labels.

The inactive-branch claim was corrected in release-branches.yml but not
in its mirror in backport-auto-label.yml, which is the workflow the claim
actually describes. `release_branches.py` returns inactive entries, so
the check loads release/v1.1 and blocks on bobbai00, while the labeler
`continue`s past the review request — a maintainer who hand-labels an
inactive branch gets a red check waiting on an approval nobody asked for.
Both copies now say so.

An empty merge-group comparison left the loop with nothing to check and
published a green context for a group whose approvals were never read.
It now fails closed like the unparseable case beside it. `min_entries_to_merge`
is 2, so a real group always carries commits and this has no known
trigger — but silent-and-green is the wrong direction for a gate.

Two wording fixes: "no release/* labels" also covered a PR based on a
release branch, which does carry them, and now says which case it is;
and the AGENTS.md line dropped the `release/*` qualifier next to a bullet
enumerating the other label families.

Report URL: https://github.com/apache/texera/actions/runs/33723396801

With regards,
GitHub Actions via GitBox

Reply via email to