The GitHub Actions job "Release Auditing" on 
texera.git/pr/computing-unit-start-diagnostics has succeeded.
Run started by GitHub user tanishqgandhi1908 (triggered by tanishqgandhi1908).

Head commit for run:
4df8c62d036a45245696adbdb4938ab429fb946f / Tanishq Gandhi 
<[email protected]>
fix(computing-unit): require only what the unit actually reads

Two of the six guarded variables lost their conf keys long ago --
USER_SYS_ENABLED with #3831, 
SCHEDULE_GENERATOR_ENABLE_COST_BASED_SCHEDULE_GENERATOR
with #3542 -- so nothing in the unit reads either. Guarding them refused to
start a unit over a variable that changes nothing whatever it is set to, and
sent whoever read the 503 to configure it: a shorter version of the search
this message exists to end. They are no longer required, or forwarded.

The four that remain are each read inside the unit: the two endpoints by
LakeFSFileDocument and ResultExportService, the payload size by
ApplicationConfig, the secret by AuthConfig.

What is forwarded is now trimmed, because a padded value passes the blank
check and reaches the pod intact, where HOCON reads " 1024" as a string and
refuses it as an int -- the unit dies at startup naming no variable. The
secret stays raw: this service signs the unit's token with it as AuthConfig
read it, and AuthConfig does not trim, so a trimmed copy would leave the two
verifying against different keys.

The amber TODO moves back onto the item it means. It had drifted onto a call
returning all six, two of which are file-service endpoints.

Report URL: https://github.com/apache/texera/actions/runs/34401192211

With regards,
GitHub Actions via GitBox

Reply via email to