The GitHub Actions job "Required Checks" on texera.git/formview-pr15a has 
succeeded.
Run started by GitHub user yangzhang75 (triggered by yangzhang75).

Head commit for run:
80640da1a31204a026dbffe97550bc8c1493d6e1 / Yang Zhang <[email protected]>
feat(gui): open the Form View's result picker to everyone, one saved list of 
shown results

The picker was the author's alone and never offered the final step. Now
everyone sees it: in edit mode a toggle sets the default for all readers
(saved in the config); anyone else, a writer merely viewing included,
changes only their own view of the page, so a reader without write access
can choose too. Nothing is written for that; the choice lasts for the page.

The final steps are offered as well, under their plain name like any other
step. What shows is one saved list, shownResultIds (mengw15's shape):
absent, every final step shows, as on the canvas; once the author has
chosen, exactly the listed steps show, and an empty list means none, a
choice the previous two opposite-signed lists (featured / turned off) could
not store and could contradict each other on. The first choice starts the
list from the final steps at that moment, so nothing the author saw
disappears; the accepted cost is that a step which becomes final after the
author has chosen does not appear by itself. A definition whose only
content is that list, an empty one included, is still persisted.

Only edit mode unlocks the graph from this page. The execute service
unlocks it whenever a run ends, for the canvas's sake; outside edit mode
the page puts the lock back at once, so a writer merely viewing cannot
reach the preview's view-result command after a run. A reader is offered
only steps whose result exists (final, or viewed on the canvas); a listed
step whose eye has gone stays offered in edit mode only, to be taken off.

The structure-locked preview no longer grows editing buttons: no link tools
on hover (remove, breakpoint), and a selected operator unfolds its state
and port counts but not its delete, chat and add/remove-port buttons. None
of them can act there, so they only suggested the preview could be edited.

Co-Authored-By: Claude Fable 5.1 <[email protected]>
Claude-Session: https://claude.ai/code/session_01FVvP3ttj22f9LB4p9u2anY

Report URL: https://github.com/apache/texera/actions/runs/34659430836

With regards,
GitHub Actions via GitBox

Reply via email to