The GitHub Actions job "Backport Checks" on 
texera.git/fix/cell-download-honours-export-switch has succeeded.
Run started by GitHub user yangzhang75 (triggered by yangzhang75).

Head commit for run:
3910c41ef772abb29302e01f640104cccbb650c4 / Yang Zhang <[email protected]>
fix(frontend): make a result cell's download work off the canvas

An export scopes itself to the operators selected on the canvas unless the
caller asked for all of them. That is the right scope for the two callers that
read the canvas: the top menu asks for everything, the context menu exports the
selection. The third caller is the download button on a result cell, and a cell
belongs to one operator, whoever happens to be selected. The same cell is also
mounted on the Form View, where the selection holds the step the user is
configuring and holds nothing at all until they click one. There the export
found an empty scope, so `performExport` returned before sending anything and
the dialog closed: a download button that did nothing, with no request, no
error and no message. The dialog's own checks read the same empty selection, so
a restricted operator went unreported there too -- with a scope of nothing,
there was nothing to report.

A caller that knows which operators it is exporting now says so, and both the
dialog and the service prefer that over the selection. The cell names the one
operator whose results it is showing. Nothing changes for the menu or the
context menu, which name none and keep the old scope.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>

Report URL: https://github.com/apache/texera/actions/runs/35172928930

With regards,
GitHub Actions via GitBox

Reply via email to