The GitHub Actions job "Required Checks" on texera.git/fix/8587-cu-picker has 
succeeded.
Run started by GitHub user mengw15 (triggered by mengw15).

Head commit for run:
95285b5852366d749c4391a8d221a43b6c3131a9 / mengw15 
<[email protected]>
fix(frontend): make the computing-unit picker say which picker it is, and let 
its button be clicked

Two pickers now sit side by side in the toolbar showing nothing but a name.
The computing-unit trigger gains the deployment-unit icon its own dashboard
tab uses, and its tooltip reads "Computing Unit: <name>" — the shape the
warehouse trigger uses, one tooltip on the control rather than one on the
badge and another on the name. The status stays where it already lives: the
badge's colour here, its words in the dropdown rows.

With nothing selected, both the trigger and the run button now name what is
missing — "Computing Unit", as the warehouse side says "Warehouse" —
instead of "Connect", so the pair reads the same way. The form view's run
button follows, since it mirrors the canvas's disable conditions.

That button was also disabled in exactly the state it exists for: the run
button's guard ended in `selectedComputingUnit?.accessPrivilege !==
Privilege.WRITE`, which with no unit selected compares against undefined and
is therefore always true, so the button offered to connect and refused every
click — leaving runWorkflow's create-unit branch unreachable, though the form
view's comments describe it as the click target. The privilege is now only
asked of a unit that exists; a unit the user may only read still refuses to
run.

The two triggers also stop looking like different controls:

- both are 200px, where sizing to content between a min and a max had made
  them visibly different widths;
- the avatar, shrunk with a transform that changes only what is drawn, kept a
  32px box that inflated a 32px-tall button, so it is sized for real instead;
- the form view matches both pickers to its Run button's height, not just the
  computing-unit one the rule predates;
- and the gap between the pickers no longer widens whenever a unit is
  running: the container's gap and the button's auto margin, both there to
  push the metrics block away, now apply to the metrics block itself.

The badge no longer claims "processing" when nothing is selected, which ant
renders as a pulsing blue dot for work that is not happening.

Closes #8587.

Report URL: https://github.com/apache/texera/actions/runs/35320823088

With regards,
GitHub Actions via GitBox

Reply via email to