The GitHub Actions job "Backport Checks" on texera.git/feat/cu-failure-states 
has succeeded.
Run started by GitHub user eugenegujing (triggered by eugenegujing).

Head commit for run:
830f261174c64c3e846197fddeb88c8862f5608f / eugenegujing 
<[email protected]>
feat(computing-unit): refuse to run on or select a unit that cannot accept work

- Add a shared unavailableComputingUnitReason helper that maps Terminating to 
"terminating" and Failed or Unknown to "unavailable". The canvas run button, 
the Form View run button and the new run guard all read it, so they share one 
definition of a terminal unit. The canvas button's labels, icons and order are 
unchanged.

- Refuse to start a run on a terminal unit in ExecuteWorkflowService, checked 
at both public entry points before the warehouse check and before the execution 
state is reset. Run-up-to and the Time Travel replay called the service 
directly without looking at the unit, so a run on a dead unit cleared the 
results on screen and was then dropped on a closed socket with no feedback.

- Give the Form View run button the terminal states the canvas already had, 
with shorter labels, and stop it from counting a terminal unit as connecting. 
Stop is offered only while the socket can deliver the kill, which also covers a 
unit that disappears from the list mid-run.

- Ignore clicks on dropdown rows the list marks unselectable. nzDisabled only 
greys the row out, so a click still selected the unit and saved it for later 
loads. The check lives in a row-only handler because creating a unit selects 
the new, Pending unit through the shared method.

- Type statusReason as string | null, which is what the backend sends to 
viewers without access.

- Add tests for both run entry points, both run buttons, the dropdown row and a 
null status reason.

Report URL: https://github.com/apache/texera/actions/runs/36077746968

With regards,
GitHub Actions via GitBox

Reply via email to