The GitHub Actions job "Required Checks" on texera.git/gh-readonly-queue/main/pr-8687-d102e26978cf0a377992b7d3ded03eaccd5d5c75 has failed. Run started by GitHub user aglinxinyuan (triggered by aglinxinyuan).
Head commit for run: 1bd43430339b067f5bbad1a816bc70ab1c228fb9 / Xinyuan Lin <[email protected]> refactor(frontend): remove the dead group-highlight streams (#8687) ### What changes were proposed in this PR? Deletes the group-highlight streams from `JointGraphWrapper`: the two subjects and the `getJointGroupHighlightStream()` / `getJointGroupUnhighlightStream()` getters. It also drops those streams from the four `merge(...)` calls that subscribe to them: one in the property editor, two in the workflow editor, and one in the operator menu. There is no behaviour change: **+6/−54 lines**. ### History | | | | --- | --- | | **Introduced by** | #754 (2020-12-11), "Added operator grouping feature", for selecting operator groups on the canvas | | **Usage removed by** | #3033 (2024-11-13), "Remove Operator Group". It deleted the feature and every `.next()` on these subjects, but kept the subjects, the getters and the subscribers | It has been dead for nearly two years. Each dropped `merge(...)` operand was a stream that never emits, so removing it changes nothing the subscribers can observe. No production code calls `.next()` or `.complete()` on either subject. > Reviewer note: the other streams in those `merge(...)` calls are live and unchanged. The only other edits are comments that still mentioned groups. `joint-graph-wrapper.spec.ts` loses its one case, which asserted that these streams stay silent when operators are highlighted. ### Any related issues, documentation, discussions? Closes #8685 ### How was this PR tested? No new tests. The one removed case only covered the deleted getters. >From `frontend/`: - `npx ng test --watch=false --include='**/joint-graph-wrapper.spec.ts' --include='**/property-editor.component.spec.ts' --include='**/workflow-editor.component.spec.ts' --include='**/operator-menu.service.spec.ts'`: 4 files, 250 tests, all pass. - `yarn format:ci`: clean. - `npx ng build`: success. To re-check: ``` git grep -n -i "JointGroup" # no hits ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Report URL: https://github.com/apache/texera/actions/runs/36278141523 With regards, GitHub Actions via GitBox
