This is an automated email from the ASF dual-hosted git repository. github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-8819-1fc75b1a2a961148e3b3479860627737d3fc1855 in repository https://gitbox.apache.org/repos/asf/texera.git
commit 00cf017d8f5e70a8070e24dbee0176ee0f1b45f6 Author: Xinyuan Lin <[email protected]> AuthorDate: Fri Oct 2 20:46:59 2026 +0000 refactor(frontend): remove unused execute-workflow types (#8819) ### What changes were proposed in this PR? Removes three exported types from `execute-workflow.interface.ts` that nothing imports: `InputPort`, `OutputPort` and `WebOutputMode`. **−9 lines.** There is no behaviour change: they are compile-time types with no reference anywhere in the repo, so they never reach the built JavaScript. `WebPaginationUpdate.mode` and `WebDataUpdate.mode` still name their mode types directly, as before. ### History | | | | --- | --- | | **Introduced by** | #1214 (2021-07-05), "Refactor frontend to handle different incremental output mode": `WebOutputMode`. #2299 (2024-01-20), "Refactor backend ports in compiler": `InputPort`, `OutputPort` | | **Usage removed by** | #7783 (2026-08-22). It deleted `OperatorAvailableResult`, whose `outputMode` field was the only use of `WebOutputMode`, and left the alias behind. `InputPort` / `OutputPort` were **never used** | The port types have been unused for the twenty months since they were added. ### Any related issues, documentation, discussions? Closes #8818 ### How was this PR tested? No new tests; these are type-only deletions. From `frontend/`: - `npx ng test --watch=false`, with one `--include` for the file's own spec plus each of the 21 specs that import it (22 files): 1412 tests pass, 1 is skipped (an existing `it.skip` elsewhere). - `npx tsc --noEmit -p src/tsconfig.app.json`: clean. - `yarn format:ci`: clean. - `npx ng build`: success. To re-check: ``` git grep -n -w -E "InputPort|OutputPort|WebOutputMode" -- frontend ':!frontend/src/app/common/type/proto' # no hits (the generated proto module has its own, unrelated InputPort/OutputPort) ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- frontend/src/app/workspace/types/execute-workflow.interface.ts | 9 --------- 1 file changed, 9 deletions(-) diff --git a/frontend/src/app/workspace/types/execute-workflow.interface.ts b/frontend/src/app/workspace/types/execute-workflow.interface.ts index a4ce01ce24..4496a40a17 100644 --- a/frontend/src/app/workspace/types/execute-workflow.interface.ts +++ b/frontend/src/app/workspace/types/execute-workflow.interface.ts @@ -30,14 +30,6 @@ export interface PortIdentity id: number; internal: boolean; }> {} -export interface OutputPort extends Readonly<{ id: PortIdentity; displayName: string }> {} -export interface InputPort - extends Readonly<{ - id: PortIdentity; - displayName: string; - disallowMultiLinks: boolean; - dependencies: ReadonlyArray<PortIdentity>; - }> {} export interface LogicalLink extends Readonly<{ @@ -115,7 +107,6 @@ export interface OperatorStatsUpdate export type PaginationMode = { type: "PaginationMode" }; export type SetSnapshotMode = { type: "SetSnapshotMode" }; export type SetDeltaMode = { type: "SetDeltaMode" }; -export type WebOutputMode = PaginationMode | SetSnapshotMode | SetDeltaMode; export interface WebPaginationUpdate extends Readonly<{
