This is an automated email from the ASF dual-hosted git repository. github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-8922-d27b7b49877bcc52d80602e57f5b0e5f86291736 in repository https://gitbox.apache.org/repos/asf/texera.git
commit a182a23e31f08e4f14d0d0beb405feb84f1e0431 Author: Xinyuan Lin <[email protected]> AuthorDate: Mon Oct 12 03:23:08 2026 +0000 refactor(frontend): remove unused dictionary URL constants (#8922) ### What changes were proposed in this PR? Removes two module-level constants from `operator-metadata.service.ts` that nothing reads: `addDictionaryAPIAddress` and `getDictionaryAPIAddress`. **−3 lines.** There is no behaviour change. The constants aren't exported, their URL strings (`/api/resources/dictionary/`, `/api/upload/dictionary/`) appear nowhere else, and the backend has no route at either path. `OPERATOR_METADATA_ENDPOINT`, which the service does use, stays. ### History | | | | --- | --- | | **Introduced by** | #696 (merged 2019-06-07), "Add saved project and dictionary upload components in user panel" | | **Usage removed by** | **never used**. No line has ever read either constant. Later removals of similar dictionary URLs (e.g. in `user-dictionary.service.ts`) were different constants | They have been unused for over six years. ### Any related issues, documentation, discussions? Closes #8921 ### How was this PR tested? No new tests; nothing referenced the constants. From `frontend/`: - `npx ng test --watch=false`, covering `operator-metadata.service.spec.ts` plus the 40 other jsdom specs that import the service: 1846 tests pass, 1 is skipped (an existing `it.skip`). - `npx ng run gui:test-browser --watch=false --include='**/code-editor.component.browser.spec.ts'` (the one browser spec that imports it): 11 tests, all pass. - `yarn format:ci`: clean. - `npx ng build`: success. To re-check: ``` git grep -n -e DictionaryAPIAddress -e "resources/dictionary" -e "upload/dictionary" # no hits ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- .../workspace/service/operator-metadata/operator-metadata.service.ts | 3 --- 1 file changed, 3 deletions(-) diff --git a/frontend/src/app/workspace/service/operator-metadata/operator-metadata.service.ts b/frontend/src/app/workspace/service/operator-metadata/operator-metadata.service.ts index 484a3c0981..ce564a302c 100644 --- a/frontend/src/app/workspace/service/operator-metadata/operator-metadata.service.ts +++ b/frontend/src/app/workspace/service/operator-metadata/operator-metadata.service.ts @@ -26,9 +26,6 @@ import { shareReplay } from "rxjs/operators"; export const OPERATOR_METADATA_ENDPOINT = "resources/operator-metadata"; -const addDictionaryAPIAddress = "/api/resources/dictionary/"; -const getDictionaryAPIAddress = "/api/upload/dictionary/"; - // interface only containing public methods export type IOperatorMetadataService = Pick<OperatorMetadataService, keyof OperatorMetadataService>;
