The GitHub Actions job "Required Checks" on 
texera.git/feat/loop-variable-refs-frontend has failed.
Run started by GitHub user aglinxinyuan (triggered by aglinxinyuan).

Head commit for run:
3823fef8c528e6110c6192eb6704002755d72a18 / Xinyuan Lin <[email protected]>
fix(frontend): leave disabled operators out of loop-block membership

The backend compiles and runs only the enabled operators and the links
between them (WorkflowGraph.getSubDAG), at the editing-time compile and
at a run. The frontend counted every operator, so disabling the Loop End
(or any operator on the only path) kept a body operator holding `$i`
inside its block in the panel and in validation, while the backend said
it was not inside a loop block. loopVariablesInScope now reads
getAllEnabledOperators/getAllEnabledLinks, and loopScopeChangeStream
also emits when an operator is disabled or enabled, so the panel and
validation look again.

Validation's re-check after an edit that touches neither the operator
holding the reference nor a neighbor of it is pinned again: the two-hop
link tests the compile-fed refactor dropped are back, plus one for a
Loop End disabled two hops away. Each fails if validation stops
listening to loopScopeChangeStream.

The shared fixture now runs the frontend stack in PR CI as well
(labeler.yml), so a fixture regenerated after a LogicalPlan change also
runs loop-block.util.spec.ts. LogicalPlanSpec reads the fixture's Loop
Start and Loop End through the backend's JSON type names, so a renamed
type fails there. This replaces the frontend test that only compared the
constants to their own literals.

Report URL: https://github.com/apache/texera/actions/runs/38509691996

With regards,
GitHub Actions via GitBox

Reply via email to