This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/texera.git

commit d9c50f229e0b4f01170c1c61da37cbcc1fff6d6f
Author: Tanishq Gandhi <[email protected]>
AuthorDate: Thu Oct 15 23:02:16 2026 +0000

    fix(k8s): make the computing-unit prepuller follow texeraImages.pullPolicy 
(#8973)
    
    ### What changes were proposed in this PR?
    
    The computing-unit prepull DaemonSet hardcoded imagePullPolicy: Always,
    so on clusters that load images into the nodes (kind, minikube,
    air-gapped) setting texeraImages.pullPolicy to IfNotPresent or Never had
    no effect on it. Its init container still tried to pull from the
    registry and failed.
    
    It now reads {{ .Values.texeraImages.pullPolicy }}, like the Jupyter
    prepull DaemonSet and every other template that pulls a Texera image.
    texeraImages.pullPolicy defaults to Always, so default installs render
    exactly as before.
    
    Rendered with helm template, before:
    ```
    pullPolicy=Always        | CU prepuller: Always | Jupyter prepuller: Always
    pullPolicy=IfNotPresent  | CU prepuller: Always | Jupyter prepuller: 
IfNotPresent
    pullPolicy=Never         | CU prepuller: Always | Jupyter prepuller: Never
    ```
    After:
    ```
    pullPolicy=Always        | CU prepuller: Always       | Jupyter prepuller: 
Always
    pullPolicy=IfNotPresent  | CU prepuller: IfNotPresent | Jupyter prepuller: 
IfNotPresent
    pullPolicy=Never         | CU prepuller: Never        | Jupyter prepuller: 
Never
    ```
    
    ### Any related issues, documentation, discussions?
    Closes #8972
    
    ### How was this PR tested?
    
    Rendered the DaemonSet with helm template under each
    texeraImages.pullPolicy value, before and after (output above), and with
    the default values, which still give Always.
    bin/k8s/tests/test_helm_values.sh passes.
    
    ### Was this PR authored or co-authored using generative AI tooling?
    Generated-by: Claude Code (Claude Opus 5.5)
    
    Co-authored-by: Meng Wang <[email protected]>
---
 .../workflow-computing-unit-master-prepull-daemonset.yaml               | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/bin/k8s/templates/base/workflow-computing-unit-pool/workflow-computing-unit-master-prepull-daemonset.yaml
 
b/bin/k8s/templates/base/workflow-computing-unit-pool/workflow-computing-unit-master-prepull-daemonset.yaml
index b85a6feedb..1726721986 100644
--- 
a/bin/k8s/templates/base/workflow-computing-unit-pool/workflow-computing-unit-master-prepull-daemonset.yaml
+++ 
b/bin/k8s/templates/base/workflow-computing-unit-pool/workflow-computing-unit-master-prepull-daemonset.yaml
@@ -40,7 +40,7 @@ spec:
       initContainers:
         - name: prepuller
           image: {{ .Values.texera.imageRegistry }}/{{ 
.Values.workflowComputingUnitPool.imageName }}:{{ .Values.texera.imageTag }}
-          imagePullPolicy: Always
+          imagePullPolicy: {{ .Values.texeraImages.pullPolicy }}
           command: ["sh", "-c", "true"]
       containers:
         - name: pause

Reply via email to