The GitHub Actions job "Backport Approval Check" on texera.git/fix/form-readonly-card-keyboard has succeeded. Run started by GitHub user yangzhang75 (triggered by yangzhang75).
Head commit for run: a963b0fb5db08473f199173af4f4449eb5a42cbd / Yang Zhang <[email protected]> fix(workflow-form): keep the keyboard out of a read-only input card, not only the pointer The card is locked with `pointer-events: none`, which is hit testing only. A keyboard user could Tab into the controls a custom widget draws of its own -- a file picker's Browse button, the HuggingFace file input -- and activate them with Enter or Space; those controls do not consult the form's disabled state the way the bound formly controls do, so the upload went out from a read-only card. A directive on the card takes every focusable descendant out of the tab order and marks it aria-disabled, re-applying when a widget renders or redraws its own controls. `inert`, which the step panel uses for its read-only mount, would also remove the card from the accessibility tree: a reader's card exists to be read, so that would trade this bug for a worse one. Report URL: https://github.com/apache/texera/actions/runs/38987329780 With regards, GitHub Actions via GitBox
