The GitHub Actions job "Backport Approval Check" on 
texera.git/fix/hub-detail-bfcache has failed.
Run started by GitHub user Yicong-Huang (triggered by Yicong-Huang).

Head commit for run:
46dedf1cd120b7c1840dcbe7c95dc11847e5a33a / Yang Zhang <[email protected]>
fix(frontend): keep a hub workflow preview alive when the browser unloads it

HubWorkflowDetailComponent bound its ngOnDestroy to window:beforeunload as
well, so leaving the page cleared the workflow out of the shared graph. But
leaving a document is not discarding it: Chrome may keep it in the back/forward
cache and restore it on the way back with its JavaScript state exactly as it
was left, re-running nothing. The preview would have come back to an empty
canvas on a page that looks live.

The binding goes; the clear stays in ngOnDestroy, which Angular runs when the
route really leaves. The same shape as #8599, fixed for the workspace and the
Form View in #8600.

AgentPanelComponent has the same binding and is deliberately left alone: it
deactivates an agent there, and whether that is releasing something server-side
that ought to be released is a judgement about that subsystem. The app's other
beforeunload bindings only write panel geometry to localStorage, which is
exactly what they should do there.

Closes #8601

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01FVvP3ttj22f9LB4p9u2anY

Report URL: https://github.com/apache/texera/actions/runs/39204844768

With regards,
GitHub Actions via GitBox

Reply via email to