This is an automated email from the ASF dual-hosted git repository. github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-9027-22b82a2958f8328be2f05044092e2b30e38c56cb in repository https://gitbox.apache.org/repos/asf/texera.git
commit 7cb79871c5f8ae9a9a966dd0ad92f28903ff07a1 Author: Xinyuan Lin <[email protected]> AuthorDate: Wed Oct 21 04:08:29 2026 +0000 refactor(frontend): remove the dead admin Gmail stylesheet (#9027) ### What changes were proposed in this PR? Deletes `admin-gmail.component.scss` and its `styleUrls` entry in `admin-gmail.component.ts`. **−27 lines.** There is no behaviour change. The stylesheet's only rule is `.form { ... }`. The component uses emulated encapsulation, so the rule can only match an element in its own template, and that template has no element with class `form`. The `<form nz-form>` element doesn't match: `.form` is a class selector, and `NzFormDirective` adds only `ant-form*` classes. Nothing else references the file (`angular.json` styles, `@use`, `@import`). With no styles left, Angular compiles the component without view emulation, so the rendered DOM only loses the generated `_ngcontent` attributes. ### History | | | | --- | --- | | **Introduced by** | #2027 (2023-10-11), "Introduce Email Notification System". It copied `.form` from the login stylesheet into the new component | | **Usage removed by** | **never used**. No version of the Gmail template has had a `form` class | It has never applied, in the three years since it was added. ### Any related issues, documentation, discussions? Closes #9024 ### How was this PR tested? No new tests; the spec never referenced the stylesheet. From `frontend/`: - `npx ng test --watch=false --include='**/admin-gmail.component.spec.ts'`: 10 tests, all pass. No other spec renders the component. - `yarn format:ci`: clean. - `npx ng build`: success. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- .../admin/gmail/admin-gmail.component.scss | 26 ---------------------- .../component/admin/gmail/admin-gmail.component.ts | 1 - 2 files changed, 27 deletions(-) diff --git a/frontend/src/app/dashboard/component/admin/gmail/admin-gmail.component.scss b/frontend/src/app/dashboard/component/admin/gmail/admin-gmail.component.scss deleted file mode 100644 index cbdaabf798..0000000000 --- a/frontend/src/app/dashboard/component/admin/gmail/admin-gmail.component.scss +++ /dev/null @@ -1,26 +0,0 @@ -/** - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ - -.form { - border: 2px solid black; - border-radius: 5px; - margin: 16px; - padding: 20px; - height: 350px; -} diff --git a/frontend/src/app/dashboard/component/admin/gmail/admin-gmail.component.ts b/frontend/src/app/dashboard/component/admin/gmail/admin-gmail.component.ts index 1771348927..04cf02e85f 100644 --- a/frontend/src/app/dashboard/component/admin/gmail/admin-gmail.component.ts +++ b/frontend/src/app/dashboard/component/admin/gmail/admin-gmail.component.ts @@ -34,7 +34,6 @@ import { ɵNzTransitionPatchDirective } from "ng-zorro-antd/core/transition-patc @Component({ selector: "texera-gmail", templateUrl: "./admin-gmail.component.html", - styleUrls: ["./admin-gmail.component.scss"], imports: [ NzCardComponent, FormsModule,
