TEZ-2471. NPE in LogicalIOProcessorRuntimeTask while printing thread info. (sseth)
Project: http://git-wip-us.apache.org/repos/asf/tez/repo Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/098aa8e0 Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/098aa8e0 Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/098aa8e0 Branch: refs/heads/TEZ-2003 Commit: 098aa8e07d994cabbccef0d8dd6867393c593900 Parents: bec3742 Author: Siddharth Seth <[email protected]> Authored: Fri May 22 11:03:11 2015 -0700 Committer: Siddharth Seth <[email protected]> Committed: Thu Aug 20 18:22:07 2015 -0700 ---------------------------------------------------------------------- TEZ-2003-CHANGES.txt | 1 + .../org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tez/blob/098aa8e0/TEZ-2003-CHANGES.txt ---------------------------------------------------------------------- diff --git a/TEZ-2003-CHANGES.txt b/TEZ-2003-CHANGES.txt index ca3383c..d651960 100644 --- a/TEZ-2003-CHANGES.txt +++ b/TEZ-2003-CHANGES.txt @@ -27,5 +27,6 @@ ALL CHANGES: TEZ-2434. Allow tasks to be killed in the Runtime. TEZ-2443. TaskRunner2 should call abort, NPEs while cleaning up tasks. TEZ-2465. Retrun the status of a kill request in TaskRunner2. + TEZ-2471. NPE in LogicalIOProcessorRuntimeTask while printing thread info. INCOMPATIBLE CHANGES: http://git-wip-us.apache.org/repos/asf/tez/blob/098aa8e0/tez-runtime-internals/src/main/java/org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java ---------------------------------------------------------------------- diff --git a/tez-runtime-internals/src/main/java/org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java b/tez-runtime-internals/src/main/java/org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java index de08e56..449fa0f 100644 --- a/tez-runtime-internals/src/main/java/org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java +++ b/tez-runtime-internals/src/main/java/org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java @@ -936,7 +936,10 @@ public class LogicalIOProcessorRuntimeTask extends RuntimeTask { long[] threadIds = threadMXBean.getAllThreadIds(); for (Long id : threadIds) { ThreadInfo threadInfo = threadMXBean.getThreadInfo(id); - LOG.info("ThreadId : " + id + ", name=" + threadInfo.getThreadName()); + // The thread could have been shutdown before we read info about it. + if (threadInfo != null) { + LOG.debug("ThreadId : " + id + ", name=" + threadInfo.getThreadName()); + } } }
