Repository: tez Updated Branches: refs/heads/master d336ebdbc -> 8c61a6609
TEZ-1888. Fix javac warnings all over codebase. Contributed by Chetna Chaudhari. Project: http://git-wip-us.apache.org/repos/asf/tez/repo Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/8c61a660 Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/8c61a660 Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/8c61a660 Branch: refs/heads/master Commit: 8c61a66098e6304dce15d7f0861069e3ee1aabfe Parents: d336ebd Author: Siddharth Seth <[email protected]> Authored: Wed Oct 21 09:55:54 2015 -0700 Committer: Siddharth Seth <[email protected]> Committed: Wed Oct 21 09:55:54 2015 -0700 ---------------------------------------------------------------------- CHANGES.txt | 1 + .../java/org/apache/tez/client/LocalClient.java | 1 + .../dag/app/rm/LocalTaskSchedulerService.java | 1 + .../org/apache/tez/state/StateMachineTez.java | 4 +++- .../dag/app/TestTaskCommunicatorManager1.java | 2 +- .../dag/app/TestTaskCommunicatorManager2.java | 2 ++ .../tez/dag/app/dag/impl/TestDAGImpl.java | 1 + .../TestDAGSchedulerNaturalOrderControlled.java | 10 +++++++--- .../tez/dag/app/dag/impl/TestVertexImpl.java | 5 ++++- .../tez/dag/app/rm/TestTaskScheduler.java | 2 +- .../dag/app/rm/TestTaskSchedulerHelpers.java | 1 + .../tez/dag/app/rm/TestTezAMRMClient.java | 2 ++ .../app/rm/container/TestAMContainerMap.java | 1 + .../TestHistoryEventsProtoConversion.java | 3 +++ .../impl/TestHistoryEventJsonConversion.java | 1 + .../mapreduce/committer/MROutputCommitter.java | 1 + .../tez/mapreduce/hadoop/mapred/MRCounters.java | 20 +++++++++++++------- .../hadoop/mapreduce/JobContextImpl.java | 1 + .../apache/tez/mapreduce/processor/MRTask.java | 2 +- .../ats/TestHistoryEventTimelineConversion.java | 4 ++++ .../conf/OrderedGroupedKVInputConfig.java | 4 ++++ .../conf/OrderedPartitionedKVOutputConfig.java | 3 +++ .../library/conf/UnorderedKVInputConfig.java | 3 +++ .../library/conf/UnorderedKVOutputConfig.java | 3 +++ .../UnorderedPartitionedKVOutputConfig.java | 3 +++ .../library/common/TestValuesIterator.java | 6 ++++++ .../common/comparator/TestProxyComparator.java | 1 + .../org/apache/tez/mapreduce/examples/Join.java | 1 + .../mapreduce/examples/RandomTextWriter.java | 1 + .../tez/mapreduce/examples/RandomWriter.java | 1 + .../tez/mapreduce/examples/SecondarySort.java | 3 ++- .../org/apache/tez/mapreduce/examples/Sort.java | 1 + .../tez/analyzer/plugins/TezAnalyzerBase.java | 4 ++-- 33 files changed, 81 insertions(+), 18 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/CHANGES.txt ---------------------------------------------------------------------- diff --git a/CHANGES.txt b/CHANGES.txt index 6f94f0a..2e5bbe7 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -6,6 +6,7 @@ Release 0.8.2: Unreleased INCOMPATIBLE CHANGES ALL CHANGES: + TEZ-1888. Fix javac warnings all over codebase. TEZ-2886. Ability to merge AM credentials with DAG credentials. TEZ-2896. Fix thread names used during Input/Output initialization. TEZ-2866. Tez UI: Newly added columns wont be displayed by default in tables http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-dag/src/main/java/org/apache/tez/client/LocalClient.java ---------------------------------------------------------------------- diff --git a/tez-dag/src/main/java/org/apache/tez/client/LocalClient.java b/tez-dag/src/main/java/org/apache/tez/client/LocalClient.java index 508f817..b225523 100644 --- a/tez-dag/src/main/java/org/apache/tez/client/LocalClient.java +++ b/tez-dag/src/main/java/org/apache/tez/client/LocalClient.java @@ -268,6 +268,7 @@ public class LocalClient extends FrameworkClient { } } + @SuppressWarnings("deprecation") protected Thread createDAGAppMaster(final ApplicationSubmissionContext appContext) { Thread thread = new Thread(new Runnable() { @Override http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-dag/src/main/java/org/apache/tez/dag/app/rm/LocalTaskSchedulerService.java ---------------------------------------------------------------------- diff --git a/tez-dag/src/main/java/org/apache/tez/dag/app/rm/LocalTaskSchedulerService.java b/tez-dag/src/main/java/org/apache/tez/dag/app/rm/LocalTaskSchedulerService.java index 668c759..7dabb73 100644 --- a/tez-dag/src/main/java/org/apache/tez/dag/app/rm/LocalTaskSchedulerService.java +++ b/tez-dag/src/main/java/org/apache/tez/dag/app/rm/LocalTaskSchedulerService.java @@ -194,6 +194,7 @@ public class LocalTaskSchedulerService extends TaskScheduler { .newInstance(appId, appAttemptId.getAttemptId()); } + @SuppressWarnings("deprecation") public Container createContainer(Resource capability, Priority priority) { ContainerId containerId = ContainerId.newInstance(customAppAttemptId, nextId.getAndIncrement()); NodeId nodeId = NodeId.newInstance("127.0.0.1", 0); http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-dag/src/main/java/org/apache/tez/state/StateMachineTez.java ---------------------------------------------------------------------- diff --git a/tez-dag/src/main/java/org/apache/tez/state/StateMachineTez.java b/tez-dag/src/main/java/org/apache/tez/state/StateMachineTez.java index 0fd3c0e..3be7718 100644 --- a/tez-dag/src/main/java/org/apache/tez/state/StateMachineTez.java +++ b/tez-dag/src/main/java/org/apache/tez/state/StateMachineTez.java @@ -34,6 +34,7 @@ public class StateMachineTez<STATE extends Enum<STATE>, EVENTTYPE extends Enum<E private final StateMachine<STATE, EVENTTYPE, EVENT> realStatemachine; + @SuppressWarnings("unchecked") public StateMachineTez(StateMachine sm, OPERAND operand) { this.realStatemachine = sm; this.operand = operand; @@ -50,6 +51,7 @@ public class StateMachineTez<STATE extends Enum<STATE>, EVENTTYPE extends Enum<E return realStatemachine.getCurrentState(); } + @SuppressWarnings("unchecked") @Override public STATE doTransition(EVENTTYPE eventType, EVENT event) throws InvalidStateTransitonException { @@ -63,4 +65,4 @@ public class StateMachineTez<STATE extends Enum<STATE>, EVENTTYPE extends Enum<E } return newState; } -} \ No newline at end of file +} http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-dag/src/test/java/org/apache/tez/dag/app/TestTaskCommunicatorManager1.java ---------------------------------------------------------------------- diff --git a/tez-dag/src/test/java/org/apache/tez/dag/app/TestTaskCommunicatorManager1.java b/tez-dag/src/test/java/org/apache/tez/dag/app/TestTaskCommunicatorManager1.java index 35893b3..03b7da9 100644 --- a/tez-dag/src/test/java/org/apache/tez/dag/app/TestTaskCommunicatorManager1.java +++ b/tez-dag/src/test/java/org/apache/tez/dag/app/TestTaskCommunicatorManager1.java @@ -418,7 +418,7 @@ public class TestTaskCommunicatorManager1 { return taskAttemptListener.heartbeat(request); } - + @SuppressWarnings("deprecation") private ContainerId createContainerId(ApplicationId applicationId, int containerIdx) { ApplicationAttemptId appAttemptId = ApplicationAttemptId.newInstance(applicationId, 1); return ContainerId.newInstance(appAttemptId, containerIdx); http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-dag/src/test/java/org/apache/tez/dag/app/TestTaskCommunicatorManager2.java ---------------------------------------------------------------------- diff --git a/tez-dag/src/test/java/org/apache/tez/dag/app/TestTaskCommunicatorManager2.java b/tez-dag/src/test/java/org/apache/tez/dag/app/TestTaskCommunicatorManager2.java index a7652a0..9700524 100644 --- a/tez-dag/src/test/java/org/apache/tez/dag/app/TestTaskCommunicatorManager2.java +++ b/tez-dag/src/test/java/org/apache/tez/dag/app/TestTaskCommunicatorManager2.java @@ -59,6 +59,7 @@ import org.mockito.ArgumentCaptor; public class TestTaskCommunicatorManager2 { + @SuppressWarnings("unchecked") @Test(timeout = 5000) public void testTaskAttemptFailedKilled() throws IOException, TezException { ApplicationId appId = ApplicationId.newInstance(1000, 1); @@ -130,6 +131,7 @@ public class TestTaskCommunicatorManager2 { // TODO TEZ-2003. Verify unregistration from the registered list } + @SuppressWarnings("deprecation") private ContainerId createContainerId(ApplicationId applicationId, int containerIdx) { ApplicationAttemptId appAttemptId = ApplicationAttemptId.newInstance(applicationId, 1); ContainerId containerId = ContainerId.newInstance(appAttemptId, containerIdx); http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-dag/src/test/java/org/apache/tez/dag/app/dag/impl/TestDAGImpl.java ---------------------------------------------------------------------- diff --git a/tez-dag/src/test/java/org/apache/tez/dag/app/dag/impl/TestDAGImpl.java b/tez-dag/src/test/java/org/apache/tez/dag/app/dag/impl/TestDAGImpl.java index 66d1012..ccff6b0 100644 --- a/tez-dag/src/test/java/org/apache/tez/dag/app/dag/impl/TestDAGImpl.java +++ b/tez-dag/src/test/java/org/apache/tez/dag/app/dag/impl/TestDAGImpl.java @@ -227,6 +227,7 @@ public class TestDAGImpl { } } + @SuppressWarnings("unchecked") private class TaskAttemptEventDisptacher2 implements EventHandler<TaskAttemptEvent> { @Override public void handle(TaskAttemptEvent event) { http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-dag/src/test/java/org/apache/tez/dag/app/dag/impl/TestDAGSchedulerNaturalOrderControlled.java ---------------------------------------------------------------------- diff --git a/tez-dag/src/test/java/org/apache/tez/dag/app/dag/impl/TestDAGSchedulerNaturalOrderControlled.java b/tez-dag/src/test/java/org/apache/tez/dag/app/dag/impl/TestDAGSchedulerNaturalOrderControlled.java index 88a91b6..bc86761 100644 --- a/tez-dag/src/test/java/org/apache/tez/dag/app/dag/impl/TestDAGSchedulerNaturalOrderControlled.java +++ b/tez-dag/src/test/java/org/apache/tez/dag/app/dag/impl/TestDAGSchedulerNaturalOrderControlled.java @@ -47,6 +47,7 @@ import org.mockito.ArgumentCaptor; public class TestDAGSchedulerNaturalOrderControlled { + @SuppressWarnings("unchecked") @Test(timeout = 5000) public void testSimpleFlow() { EventHandler eventHandler = mock(EventHandler.class); @@ -104,6 +105,7 @@ public class TestDAGSchedulerNaturalOrderControlled { reset(eventHandler); } + @SuppressWarnings("unchecked") @Test(timeout = 5000) public void testSourceRequestDelayed() { // ShuffleVertexHandler - slowstart simulation @@ -172,6 +174,7 @@ public class TestDAGSchedulerNaturalOrderControlled { } + @SuppressWarnings("unchecked") @Test(timeout = 5000) public void testParallelismUpdated() { EventHandler eventHandler = mock(EventHandler.class); @@ -222,6 +225,7 @@ public class TestDAGSchedulerNaturalOrderControlled { reset(eventHandler); } + @SuppressWarnings("unchecked") @Test(timeout = 5000) public void testMultipleRequestsForSameTask() { EventHandler eventHandler = mock(EventHandler.class); @@ -306,16 +310,16 @@ public class TestDAGSchedulerNaturalOrderControlled { } - updateMockVertexWithConnections(vertices[0], createConnectionMap(null), + updateMockVertexWithConnections(vertices[0], createConnectionMap((Vertex[]) null), createConnectionMap(vertices[2])); - updateMockVertexWithConnections(vertices[1], createConnectionMap(null), + updateMockVertexWithConnections(vertices[1], createConnectionMap((Vertex[]) null), createConnectionMap(vertices[3])); updateMockVertexWithConnections(vertices[2], createConnectionMap(vertices[0]), createConnectionMap(vertices[4])); updateMockVertexWithConnections(vertices[3], createConnectionMap(vertices[1]), createConnectionMap(vertices[4])); updateMockVertexWithConnections(vertices[4], createConnectionMap(vertices[2], vertices[3]), - createConnectionMap(null)); + createConnectionMap((Vertex[]) null)); return dag; } http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-dag/src/test/java/org/apache/tez/dag/app/dag/impl/TestVertexImpl.java ---------------------------------------------------------------------- diff --git a/tez-dag/src/test/java/org/apache/tez/dag/app/dag/impl/TestVertexImpl.java b/tez-dag/src/test/java/org/apache/tez/dag/app/dag/impl/TestVertexImpl.java index eb95bf9..035de32 100644 --- a/tez-dag/src/test/java/org/apache/tez/dag/app/dag/impl/TestVertexImpl.java +++ b/tez-dag/src/test/java/org/apache/tez/dag/app/dag/impl/TestVertexImpl.java @@ -3432,7 +3432,8 @@ public class TestVertexImpl { Assert.assertEquals(0, committer.commitCounter); Assert.assertEquals(1, committer.abortCounter); } - + + @SuppressWarnings("deprecation") @Test(timeout = 5000) public void testVertexTaskAttemptProcessorFailure() throws Exception { initAllVertices(VertexState.INITED); @@ -3468,6 +3469,7 @@ public class TestVertexImpl { Assert.assertEquals(TaskAttemptTerminationCause.APPLICATION_ERROR, ta.getTerminationCause()); } + @SuppressWarnings("deprecation") @Test(timeout = 5000) public void testVertexTaskAttemptInputFailure() throws Exception { initAllVertices(VertexState.INITED); @@ -3504,6 +3506,7 @@ public class TestVertexImpl { } + @SuppressWarnings("deprecation") @Test(timeout = 5000) public void testVertexTaskAttemptOutputFailure() throws Exception { initAllVertices(VertexState.INITED); http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-dag/src/test/java/org/apache/tez/dag/app/rm/TestTaskScheduler.java ---------------------------------------------------------------------- diff --git a/tez-dag/src/test/java/org/apache/tez/dag/app/rm/TestTaskScheduler.java b/tez-dag/src/test/java/org/apache/tez/dag/app/rm/TestTaskScheduler.java index c012c1e..f69d8be 100644 --- a/tez-dag/src/test/java/org/apache/tez/dag/app/rm/TestTaskScheduler.java +++ b/tez-dag/src/test/java/org/apache/tez/dag/app/rm/TestTaskScheduler.java @@ -88,7 +88,7 @@ import org.mockito.stubbing.Answer; import com.google.common.collect.Sets; - +@SuppressWarnings("deprecation") public class TestTaskScheduler { static ContainerSignatureMatcher containerSignatureMatcher = new AlwaysMatchesContainerMatcher(); http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-dag/src/test/java/org/apache/tez/dag/app/rm/TestTaskSchedulerHelpers.java ---------------------------------------------------------------------- diff --git a/tez-dag/src/test/java/org/apache/tez/dag/app/rm/TestTaskSchedulerHelpers.java b/tez-dag/src/test/java/org/apache/tez/dag/app/rm/TestTaskSchedulerHelpers.java index b1bc491..8b489ea 100644 --- a/tez-dag/src/test/java/org/apache/tez/dag/app/rm/TestTaskSchedulerHelpers.java +++ b/tez-dag/src/test/java/org/apache/tez/dag/app/rm/TestTaskSchedulerHelpers.java @@ -146,6 +146,7 @@ class TestTaskSchedulerHelpers { this.defaultPayload = defaultPayload; } + @SuppressWarnings("unchecked") @Override public void instantiateSchedulers(String host, int port, String trackingUrl, AppContext appContext) { http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-dag/src/test/java/org/apache/tez/dag/app/rm/TestTezAMRMClient.java ---------------------------------------------------------------------- diff --git a/tez-dag/src/test/java/org/apache/tez/dag/app/rm/TestTezAMRMClient.java b/tez-dag/src/test/java/org/apache/tez/dag/app/rm/TestTezAMRMClient.java index d01ebbf..9bb3aff 100644 --- a/tez-dag/src/test/java/org/apache/tez/dag/app/rm/TestTezAMRMClient.java +++ b/tez-dag/src/test/java/org/apache/tez/dag/app/rm/TestTezAMRMClient.java @@ -46,6 +46,7 @@ public class TestTezAMRMClient { MockDNSToSwitchMapping.initializeMockRackResolver(); } + @SuppressWarnings("unchecked") @Before public void setup() { amrmClient = new TezAMRMClientAsync(new AMRMClientImpl(), @@ -58,6 +59,7 @@ public class TestTezAMRMClient { amrmClient = null; } + @SuppressWarnings("unchecked") @Test(timeout=10000) public void testMatchingRequestsForTopPriority() { String[] hosts = { "host1" }; http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-dag/src/test/java/org/apache/tez/dag/app/rm/container/TestAMContainerMap.java ---------------------------------------------------------------------- diff --git a/tez-dag/src/test/java/org/apache/tez/dag/app/rm/container/TestAMContainerMap.java b/tez-dag/src/test/java/org/apache/tez/dag/app/rm/container/TestAMContainerMap.java index 0230bb5..31d756c 100644 --- a/tez-dag/src/test/java/org/apache/tez/dag/app/rm/container/TestAMContainerMap.java +++ b/tez-dag/src/test/java/org/apache/tez/dag/app/rm/container/TestAMContainerMap.java @@ -55,6 +55,7 @@ public class TestAMContainerMap { return appContext; } + @SuppressWarnings("deprecation") private ContainerId mockContainerId(int cId) { ApplicationId appId = ApplicationId.newInstance(1000, 1); ApplicationAttemptId appAttemptId = ApplicationAttemptId.newInstance(appId, 1); http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-dag/src/test/java/org/apache/tez/dag/history/events/TestHistoryEventsProtoConversion.java ---------------------------------------------------------------------- diff --git a/tez-dag/src/test/java/org/apache/tez/dag/history/events/TestHistoryEventsProtoConversion.java b/tez-dag/src/test/java/org/apache/tez/dag/history/events/TestHistoryEventsProtoConversion.java index b0b76d4..57a849b 100644 --- a/tez-dag/src/test/java/org/apache/tez/dag/history/events/TestHistoryEventsProtoConversion.java +++ b/tez-dag/src/test/java/org/apache/tez/dag/history/events/TestHistoryEventsProtoConversion.java @@ -473,6 +473,7 @@ public class TestHistoryEventsProtoConversion { } } + @SuppressWarnings("deprecation") private void testTaskAttemptStartedEvent() throws Exception { TaskAttemptStartedEvent event = new TaskAttemptStartedEvent( TezTaskAttemptID.getInstance(TezTaskID.getInstance(TezVertexID.getInstance( @@ -557,6 +558,7 @@ public class TestHistoryEventsProtoConversion { } } + @SuppressWarnings("deprecation") private void testContainerLaunchedEvent() throws Exception { ContainerLaunchedEvent event = new ContainerLaunchedEvent( ContainerId.newInstance(ApplicationAttemptId.newInstance( @@ -574,6 +576,7 @@ public class TestHistoryEventsProtoConversion { logEvents(event, deserializedEvent); } + @SuppressWarnings("deprecation") private void testContainerStoppedEvent() throws Exception { ContainerStoppedEvent event = new ContainerStoppedEvent( ContainerId.newInstance(ApplicationAttemptId.newInstance( http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-dag/src/test/java/org/apache/tez/dag/history/logging/impl/TestHistoryEventJsonConversion.java ---------------------------------------------------------------------- diff --git a/tez-dag/src/test/java/org/apache/tez/dag/history/logging/impl/TestHistoryEventJsonConversion.java b/tez-dag/src/test/java/org/apache/tez/dag/history/logging/impl/TestHistoryEventJsonConversion.java index cfe9618..bcc3859 100644 --- a/tez-dag/src/test/java/org/apache/tez/dag/history/logging/impl/TestHistoryEventJsonConversion.java +++ b/tez-dag/src/test/java/org/apache/tez/dag/history/logging/impl/TestHistoryEventJsonConversion.java @@ -93,6 +93,7 @@ public class TestHistoryEventJsonConversion { private ContainerId containerId; private NodeId nodeId; + @SuppressWarnings("deprecation") @Before public void setup() { applicationId = ApplicationId.newInstance(9999l, 1); http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/committer/MROutputCommitter.java ---------------------------------------------------------------------- diff --git a/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/committer/MROutputCommitter.java b/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/committer/MROutputCommitter.java index 1b66c8e..b7ebc4c 100644 --- a/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/committer/MROutputCommitter.java +++ b/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/committer/MROutputCommitter.java @@ -186,6 +186,7 @@ public class MROutputCommitter extends OutputCommitter { } + @SuppressWarnings("deprecation") @Override public boolean isTaskRecoverySupported() { if (!initialized) { http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/mapred/MRCounters.java ---------------------------------------------------------------------- diff --git a/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/mapred/MRCounters.java b/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/mapred/MRCounters.java index 6563a05..cc9b6ba 100644 --- a/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/mapred/MRCounters.java +++ b/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/mapred/MRCounters.java @@ -71,6 +71,7 @@ public class MRCounters extends org.apache.hadoop.mapred.Counters { return new MRCounter(raw.findCounter(group, name)); } + @Deprecated @Override public Counter findCounter(String group, int id, String name) { return new MRCounter(raw.findCounter(group, name)); @@ -104,7 +105,8 @@ public class MRCounters extends org.apache.hadoop.mapred.Counters { } } } - + + @Deprecated @Override public int size() { return countCounters(); @@ -150,22 +152,24 @@ public class MRCounters extends org.apache.hadoop.mapred.Counters { public int size() { return group.size(); } + @SuppressWarnings("unchecked") + @Override + public org.apache.hadoop.mapreduce.counters.CounterGroupBase + getUnderlyingGroup() { + return new MRCounterGroup(group).getUnderlyingGroup(); + } @Override public void incrAllCounters( org.apache.hadoop.mapreduce.counters.CounterGroupBase rightGroup) { new MRCounterGroup(group).incrAllCounters(rightGroup); } @Override - public org.apache.hadoop.mapreduce.counters.CounterGroupBase - getUnderlyingGroup() { - return new MRCounterGroup(group).getUnderlyingGroup(); - } - @Override public void readFields(DataInput arg0) throws IOException { } @Override public void write(DataOutput arg0) throws IOException { } + @SuppressWarnings("unchecked") @Override public Iterator iterator() { // FIXME? @@ -208,6 +212,7 @@ public class MRCounters extends org.apache.hadoop.mapred.Counters { this.raw = raw; } + @SuppressWarnings("deprecation") @Override public void setDisplayName(String displayName) { // TODO Auto-generated method stub @@ -282,7 +287,8 @@ public class MRCounters extends org.apache.hadoop.mapred.Counters { return raw.hashCode(); } } - + + @SuppressWarnings("unchecked") static org.apache.tez.common.counters.TezCounter convert( org.apache.hadoop.mapred.Counters.Counter counter) { org.apache.hadoop.mapreduce.Counter underlyingCounter = http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/mapreduce/JobContextImpl.java ---------------------------------------------------------------------- diff --git a/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/mapreduce/JobContextImpl.java b/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/mapreduce/JobContextImpl.java index 64414c9..1a0277c 100644 --- a/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/mapreduce/JobContextImpl.java +++ b/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/mapreduce/JobContextImpl.java @@ -52,6 +52,7 @@ import org.apache.tez.mapreduce.processor.MRTaskReporter; * A read-only view of the job that is provided to the tasks while they * are running. */ +@SuppressWarnings("deprecation") @InterfaceAudience.Private @InterfaceStability.Unstable public class JobContextImpl implements JobContext { http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/processor/MRTask.java ---------------------------------------------------------------------- diff --git a/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/processor/MRTask.java b/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/processor/MRTask.java index ed9f5fc..3f0881e 100644 --- a/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/processor/MRTask.java +++ b/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/processor/MRTask.java @@ -84,7 +84,6 @@ import org.apache.tez.runtime.api.ProcessorContext; import org.apache.tez.runtime.library.common.Constants; import org.apache.tez.runtime.library.common.sort.impl.TezRawKeyValueIterator; -@SuppressWarnings("deprecation") @Private public abstract class MRTask extends AbstractLogicalIOProcessor { @@ -265,6 +264,7 @@ public abstract class MRTask extends AbstractLogicalIOProcessor { * @param job * @throws IOException */ + @SuppressWarnings("deprecation") private static void setupDistributedCacheConfig(final JobConf job) throws IOException { http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-plugins/tez-yarn-timeline-history/src/test/java/org/apache/tez/dag/history/logging/ats/TestHistoryEventTimelineConversion.java ---------------------------------------------------------------------- diff --git a/tez-plugins/tez-yarn-timeline-history/src/test/java/org/apache/tez/dag/history/logging/ats/TestHistoryEventTimelineConversion.java b/tez-plugins/tez-yarn-timeline-history/src/test/java/org/apache/tez/dag/history/logging/ats/TestHistoryEventTimelineConversion.java index 0ad1b43..97d0b64 100644 --- a/tez-plugins/tez-yarn-timeline-history/src/test/java/org/apache/tez/dag/history/logging/ats/TestHistoryEventTimelineConversion.java +++ b/tez-plugins/tez-yarn-timeline-history/src/test/java/org/apache/tez/dag/history/logging/ats/TestHistoryEventTimelineConversion.java @@ -106,6 +106,7 @@ public class TestHistoryEventTimelineConversion { private NodeId nodeId; private String containerLogs = "containerLogs"; + @SuppressWarnings("deprecation") @Before public void setup() { applicationId = ApplicationId.newInstance(9999l, 1); @@ -232,6 +233,7 @@ public class TestHistoryEventTimelineConversion { } + @SuppressWarnings("unchecked") @Test(timeout = 5000) public void testConvertAppLaunchedEvent() { long launchTime = random.nextLong(); @@ -538,6 +540,7 @@ public class TestHistoryEventTimelineConversion { Assert.assertTrue(otherInfo.containsKey(ATSConstants.COUNTERS)); } + @SuppressWarnings("unchecked") @Test(timeout = 5000) public void testConvertDAGInitializedEvent() { long initTime = random.nextLong(); @@ -869,6 +872,7 @@ public class TestHistoryEventTimelineConversion { Assert.assertTrue(otherInfo.containsKey(ATSConstants.COUNTERS)); } + @SuppressWarnings("unchecked") @Test(timeout = 5000) public void testConvertVertexParallelismUpdatedEvent() { TezVertexID vId = tezVertexID; http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/OrderedGroupedKVInputConfig.java ---------------------------------------------------------------------- diff --git a/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/OrderedGroupedKVInputConfig.java b/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/OrderedGroupedKVInputConfig.java index 888f61a..95d8e75 100644 --- a/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/OrderedGroupedKVInputConfig.java +++ b/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/OrderedGroupedKVInputConfig.java @@ -407,6 +407,8 @@ public class OrderedGroupedKVInputConfig { } return this; } + + @SuppressWarnings("unchecked") @Override public Builder setAdditionalConfiguration(String key, String value) { Preconditions.checkNotNull(key, "Key cannot be null"); @@ -423,6 +425,7 @@ public class OrderedGroupedKVInputConfig { return this; } + @SuppressWarnings("unchecked") @Override public Builder setAdditionalConfiguration(Map<String, String> confMap) { Preconditions.checkNotNull(confMap, "ConfMap cannot be null"); @@ -433,6 +436,7 @@ public class OrderedGroupedKVInputConfig { return this; } + @SuppressWarnings("unchecked") @Override public Builder setFromConfiguration(Configuration conf) { // Maybe ensure this is the first call ? Otherwise this can end up overriding other parameters http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/OrderedPartitionedKVOutputConfig.java ---------------------------------------------------------------------- diff --git a/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/OrderedPartitionedKVOutputConfig.java b/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/OrderedPartitionedKVOutputConfig.java index 3281617..0687e79 100644 --- a/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/OrderedPartitionedKVOutputConfig.java +++ b/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/OrderedPartitionedKVOutputConfig.java @@ -334,6 +334,7 @@ public class OrderedPartitionedKVOutputConfig { } + @SuppressWarnings("unchecked") @Override public Builder setAdditionalConfiguration(String key, String value) { Preconditions.checkNotNull(key, "Key cannot be null"); @@ -350,6 +351,7 @@ public class OrderedPartitionedKVOutputConfig { return this; } + @SuppressWarnings("unchecked") @Override public Builder setAdditionalConfiguration(Map<String, String> confMap) { Preconditions.checkNotNull(confMap, "ConfMap cannot be null"); @@ -360,6 +362,7 @@ public class OrderedPartitionedKVOutputConfig { return this; } + @SuppressWarnings("unchecked") @Override public Builder setFromConfiguration(Configuration conf) { // Maybe ensure this is the first call ? Otherwise this can end up overriding other parameters http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/UnorderedKVInputConfig.java ---------------------------------------------------------------------- diff --git a/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/UnorderedKVInputConfig.java b/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/UnorderedKVInputConfig.java index e99b0bf..f52c672 100644 --- a/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/UnorderedKVInputConfig.java +++ b/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/UnorderedKVInputConfig.java @@ -256,6 +256,7 @@ public class UnorderedKVInputConfig { return this; } + @SuppressWarnings("unchecked") @Override public Builder setAdditionalConfiguration(String key, String value) { Preconditions.checkNotNull(key, "Key cannot be null"); @@ -272,6 +273,7 @@ public class UnorderedKVInputConfig { return this; } + @SuppressWarnings("unchecked") @Override public Builder setAdditionalConfiguration(Map<String, String> confMap) { Preconditions.checkNotNull(confMap, "ConfMap cannot be null"); @@ -282,6 +284,7 @@ public class UnorderedKVInputConfig { return this; } + @SuppressWarnings("unchecked") @Override public Builder setFromConfiguration(Configuration conf) { // Maybe ensure this is the first call ? Otherwise this can end up overriding other parameters http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/UnorderedKVOutputConfig.java ---------------------------------------------------------------------- diff --git a/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/UnorderedKVOutputConfig.java b/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/UnorderedKVOutputConfig.java index 30df2e3..e3eeedc 100644 --- a/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/UnorderedKVOutputConfig.java +++ b/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/UnorderedKVOutputConfig.java @@ -182,6 +182,7 @@ public class UnorderedKVOutputConfig { return this; } + @SuppressWarnings("unchecked") @Override public Builder setAdditionalConfiguration(String key, String value) { Preconditions.checkNotNull(key, "Key cannot be null"); @@ -198,6 +199,7 @@ public class UnorderedKVOutputConfig { return this; } + @SuppressWarnings("unchecked") @Override public Builder setAdditionalConfiguration(Map<String, String> confMap) { Preconditions.checkNotNull(confMap, "ConfMap cannot be null"); @@ -208,6 +210,7 @@ public class UnorderedKVOutputConfig { return this; } + @SuppressWarnings("unchecked") @Override public Builder setFromConfiguration(Configuration conf) { // Maybe ensure this is the first call ? Otherwise this can end up overriding other parameters http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/UnorderedPartitionedKVOutputConfig.java ---------------------------------------------------------------------- diff --git a/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/UnorderedPartitionedKVOutputConfig.java b/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/UnorderedPartitionedKVOutputConfig.java index 0c8cd0d..1cf0924 100644 --- a/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/UnorderedPartitionedKVOutputConfig.java +++ b/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/conf/UnorderedPartitionedKVOutputConfig.java @@ -226,6 +226,7 @@ public class UnorderedPartitionedKVOutputConfig { return this; } + @SuppressWarnings("unchecked") @Override public Builder setAdditionalConfiguration(String key, String value) { Preconditions.checkNotNull(key, "Key cannot be null"); @@ -242,6 +243,7 @@ public class UnorderedPartitionedKVOutputConfig { return this; } + @SuppressWarnings("unchecked") @Override public Builder setAdditionalConfiguration(Map<String, String> confMap) { Preconditions.checkNotNull(confMap, "ConfMap cannot be null"); @@ -252,6 +254,7 @@ public class UnorderedPartitionedKVOutputConfig { return this; } + @SuppressWarnings("unchecked") @Override public Builder setFromConfiguration(Configuration conf) { // Maybe ensure this is the first call ? Otherwise this can end up overriding other parameters http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-runtime-library/src/test/java/org/apache/tez/runtime/library/common/TestValuesIterator.java ---------------------------------------------------------------------- diff --git a/tez-runtime-library/src/test/java/org/apache/tez/runtime/library/common/TestValuesIterator.java b/tez-runtime-library/src/test/java/org/apache/tez/runtime/library/common/TestValuesIterator.java index f62179a..f3f0f6a 100644 --- a/tez-runtime-library/src/test/java/org/apache/tez/runtime/library/common/TestValuesIterator.java +++ b/tez-runtime-library/src/test/java/org/apache/tez/runtime/library/common/TestValuesIterator.java @@ -224,6 +224,7 @@ public class TestValuesIterator { } } + @SuppressWarnings("unchecked") private ValuesIterator createEmptyIterator(boolean inMemory) throws IOException, InterruptedException { if (!inMemory) { @@ -257,6 +258,7 @@ public class TestValuesIterator { * @return List * @throws IOException */ + @SuppressWarnings("unchecked") private List<Integer> verifyIteratorData( ValuesIterator valuesIterator) throws IOException { boolean result = true; @@ -324,6 +326,7 @@ public class TestValuesIterator { * @return ValuesIterator * @throws IOException */ + @SuppressWarnings("unchecked") private ValuesIterator createIterator(boolean inMemory) throws IOException, InterruptedException { if (!inMemory) { streamPaths = createFiles(); @@ -354,6 +357,7 @@ public class TestValuesIterator { * @return ValuesIterator * @throws IOException */ + @SuppressWarnings("unchecked") private ValuesIterator createCountedIterator(boolean inMemory, TezCounter keyCounter, TezCounter tupleCounter) throws IOException, InterruptedException { if (!inMemory) { @@ -478,6 +482,7 @@ public class TestValuesIterator { * @return * @throws IOException */ + @SuppressWarnings("unchecked") public List<TezMerger.Segment> createInMemStreams() throws IOException { int numberOfStreams = Math.max(2, rnd.nextInt(10)); LOG.info("No of streams : " + numberOfStreams); @@ -540,6 +545,7 @@ public class TestValuesIterator { return inputContext; } + @SuppressWarnings("unchecked") private Map<Writable, Writable> createData() { Map<Writable, Writable> map = new TreeMap<Writable, Writable>(comparator); for (int j = 0; j < Math.max(10, rnd.nextInt(50)); j++) { http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-runtime-library/src/test/java/org/apache/tez/runtime/library/common/comparator/TestProxyComparator.java ---------------------------------------------------------------------- diff --git a/tez-runtime-library/src/test/java/org/apache/tez/runtime/library/common/comparator/TestProxyComparator.java b/tez-runtime-library/src/test/java/org/apache/tez/runtime/library/common/comparator/TestProxyComparator.java index 292e912..c2f6e2d 100644 --- a/tez-runtime-library/src/test/java/org/apache/tez/runtime/library/common/comparator/TestProxyComparator.java +++ b/tez-runtime-library/src/test/java/org/apache/tez/runtime/library/common/comparator/TestProxyComparator.java @@ -56,6 +56,7 @@ public class TestProxyComparator { public void cleanup() throws Exception { } + @SuppressWarnings("unchecked") @Test(timeout = 5000) public void testProxyComparator() { final ProxyComparator<BytesWritable> comparator = new TezBytesComparator(); http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/Join.java ---------------------------------------------------------------------- diff --git a/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/Join.java b/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/Join.java index df8b247..92be836 100644 --- a/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/Join.java +++ b/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/Join.java @@ -79,6 +79,7 @@ public class Join extends Configured implements Tool { * @throws Exception When there is communication problems with the * job tracker. */ + @SuppressWarnings("deprecation") public int run(String[] args) throws Exception { Configuration conf = getConf(); JobClient client = new JobClient(conf); http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/RandomTextWriter.java ---------------------------------------------------------------------- diff --git a/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/RandomTextWriter.java b/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/RandomTextWriter.java index 8858d76..55404ba 100644 --- a/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/RandomTextWriter.java +++ b/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/RandomTextWriter.java @@ -173,6 +173,7 @@ public class RandomTextWriter extends Configured implements Tool { * * @throws IOException */ + @SuppressWarnings("deprecation") public int run(String[] args) throws Exception { if (args.length == 0) { return printUsage(); http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/RandomWriter.java ---------------------------------------------------------------------- diff --git a/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/RandomWriter.java b/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/RandomWriter.java index a44c2c3..1627d68 100644 --- a/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/RandomWriter.java +++ b/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/RandomWriter.java @@ -236,6 +236,7 @@ public class RandomWriter extends Configured implements Tool { * * @throws IOException */ + @SuppressWarnings("deprecation") public int run(String[] args) throws Exception { if (args.length == 0) { System.out.println("Usage: writer <out-dir>"); http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/SecondarySort.java ---------------------------------------------------------------------- diff --git a/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/SecondarySort.java b/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/SecondarySort.java index 869a77d..f42d08a 100644 --- a/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/SecondarySort.java +++ b/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/SecondarySort.java @@ -209,7 +209,8 @@ public class SecondarySort extends Configured implements Tool { } } } - + + @SuppressWarnings("deprecation") @Override public int run(String[] args) throws Exception { Configuration conf = getConf(); http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/Sort.java ---------------------------------------------------------------------- diff --git a/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/Sort.java b/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/Sort.java index 6e1909e..9a08b74 100644 --- a/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/Sort.java +++ b/tez-tests/src/main/java/org/apache/tez/mapreduce/examples/Sort.java @@ -80,6 +80,7 @@ public class Sort<K,V> extends Configured implements Tool { * @throws java.lang.Exception When there is communication problems with the * job tracker. */ + @SuppressWarnings("deprecation") public int run(String[] args) throws Exception { Configuration conf = getConf(); http://git-wip-us.apache.org/repos/asf/tez/blob/8c61a660/tez-tools/analyzers/job-analyzer/src/main/java/org/apache/tez/analyzer/plugins/TezAnalyzerBase.java ---------------------------------------------------------------------- diff --git a/tez-tools/analyzers/job-analyzer/src/main/java/org/apache/tez/analyzer/plugins/TezAnalyzerBase.java b/tez-tools/analyzers/job-analyzer/src/main/java/org/apache/tez/analyzer/plugins/TezAnalyzerBase.java index e63e97b..73e731a 100644 --- a/tez-tools/analyzers/job-analyzer/src/main/java/org/apache/tez/analyzer/plugins/TezAnalyzerBase.java +++ b/tez-tools/analyzers/job-analyzer/src/main/java/org/apache/tez/analyzer/plugins/TezAnalyzerBase.java @@ -199,12 +199,12 @@ public abstract class TezAnalyzerBase extends Configured implements Tool, Analyz } System.out.println(separator); - System.out.println(String.format(format.toString(), headers)); + System.out.println(String.format(format.toString(), (String[]) headers)); System.out.println(separator); Iterator<String[]> recordsIterator = ((CSVResult) result).getRecordsIterator(); while (recordsIterator.hasNext()) { - String line = String.format(format, recordsIterator.next()); + String line = String.format(format, (String[]) recordsIterator.next()); System.out.println(line); } System.out.println(separator);
