Repository: tez Updated Branches: refs/heads/master 11327804c -> d3fd82832
TEZ-3352. MRInputHelpers getStringProperty() should not fail if property value is null. (Prasanth Jayachandran via hitesh) Project: http://git-wip-us.apache.org/repos/asf/tez/repo Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/d3fd8283 Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/d3fd8283 Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/d3fd8283 Branch: refs/heads/master Commit: d3fd82832a890b49dd4955f36438dbb5230d9349 Parents: 1132780 Author: Hitesh Shah <[email protected]> Authored: Tue Aug 16 14:14:24 2016 -0700 Committer: Hitesh Shah <[email protected]> Committed: Tue Aug 16 14:14:24 2016 -0700 ---------------------------------------------------------------------- CHANGES.txt | 2 ++ .../java/org/apache/tez/mapreduce/hadoop/MRInputHelpers.java | 6 ++---- 2 files changed, 4 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tez/blob/d3fd8283/CHANGES.txt ---------------------------------------------------------------------- diff --git a/CHANGES.txt b/CHANGES.txt index 081bd8a..62c69b0 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -7,6 +7,7 @@ INCOMPATIBLE CHANGES ALL CHANGES: + TEZ-3352. MRInputHelpers getStringProperty() should not fail if property value is null. TEZ-3409. Log dagId along with other information when submitting a dag. TEZ-3384. Fix TestATSV15HistoryLoggingService::testDAGGroupingGroupingEnabled unit test. TEZ-3382. Tez analyzer: Should be resilient to new counters. @@ -96,6 +97,7 @@ INCOMPATIBLE CHANGES ALL CHANGES: + TEZ-3352. MRInputHelpers getStringProperty() should not fail if property value is null. TEZ-3409. Log dagId along with other information when submitting a dag. TEZ-3384. Fix TestATSV15HistoryLoggingService::testDAGGroupingGroupingEnabled unit test. TEZ-3376. Fix groupId generation to account for dagId starting with 1. http://git-wip-us.apache.org/repos/asf/tez/blob/d3fd8283/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/MRInputHelpers.java ---------------------------------------------------------------------- diff --git a/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/MRInputHelpers.java b/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/MRInputHelpers.java index 2a806ab..6262e59 100644 --- a/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/MRInputHelpers.java +++ b/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/MRInputHelpers.java @@ -709,10 +709,8 @@ public class MRInputHelpers { private static String getStringProperty(Configuration conf, String propertyName) { Preconditions.checkNotNull(conf, "Configuration must be provided"); - String propertyString = conf.get(propertyName); - Preconditions.checkNotNull(propertyString, - "Property " + propertyName + " not found in provided configuration"); - return propertyString; + Preconditions.checkNotNull(propertyName, "Property name must be provided"); + return conf.get(propertyName); } private static int getIntProperty(Configuration conf, String propertyName) {
