Repository: tez Updated Branches: refs/heads/master 6d3c02c91 -> 34fc31029
TEZ-3591. Tez UI: Logs url in all DAGs doesn't open in a new window (sree) Project: http://git-wip-us.apache.org/repos/asf/tez/repo Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/34fc3102 Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/34fc3102 Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/34fc3102 Branch: refs/heads/master Commit: 34fc310295d385ad7286cfa98862a4947894359c Parents: 6d3c02c Author: Sreenath Somarajapuram <[email protected]> Authored: Thu Feb 2 13:42:12 2017 +0530 Committer: Sreenath Somarajapuram <[email protected]> Committed: Thu Feb 2 13:42:12 2017 +0530 ---------------------------------------------------------------------- CHANGES.txt | 1 + tez-ui/src/main/webapp/app/controllers/dag/index.js | 5 +++++ tez-ui/src/main/webapp/app/templates/dag/index.hbs | 2 +- tez-ui/src/main/webapp/tests/unit/controllers/dag/index-test.js | 1 + 4 files changed, 8 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tez/blob/34fc3102/CHANGES.txt ---------------------------------------------------------------------- diff --git a/CHANGES.txt b/CHANGES.txt index 88398fe..65a2247 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -181,6 +181,7 @@ ALL CHANGES: TEZ-3575. RM have started forwarding origin. Use that in AMWebController for CORS support TEZ-3494. Support relative url for tez-ui.history-url.base config TEZ-3554. Add a link to get to all logs from Tez UI while job is running + TEZ-3591. Tez UI: Logs url in all DAGs doesn't open in a new window Release 0.8.5: Unreleased http://git-wip-us.apache.org/repos/asf/tez/blob/34fc3102/tez-ui/src/main/webapp/app/controllers/dag/index.js ---------------------------------------------------------------------- diff --git a/tez-ui/src/main/webapp/app/controllers/dag/index.js b/tez-ui/src/main/webapp/app/controllers/dag/index.js index 9745328..9a5b8ab 100644 --- a/tez-ui/src/main/webapp/app/controllers/dag/index.js +++ b/tez-ui/src/main/webapp/app/controllers/dag/index.js @@ -19,4 +19,9 @@ import PageController from '../page'; export default PageController.extend({ + + logLinkDefinition: { + target: "_blank" + } + }); http://git-wip-us.apache.org/repos/asf/tez/blob/34fc3102/tez-ui/src/main/webapp/app/templates/dag/index.hbs ---------------------------------------------------------------------- diff --git a/tez-ui/src/main/webapp/app/templates/dag/index.hbs b/tez-ui/src/main/webapp/app/templates/dag/index.hbs index 068fb62..4876b58 100644 --- a/tez-ui/src/main/webapp/app/templates/dag/index.hbs +++ b/tez-ui/src/main/webapp/app/templates/dag/index.hbs @@ -72,7 +72,7 @@ <tr> <td>Logs</td> <td> - {{em-table-linked-cell content=model.containerLogs}} + {{em-table-linked-cell content=model.containerLogs definition=logLinkDefinition}} </td> </tr> </tbody> http://git-wip-us.apache.org/repos/asf/tez/blob/34fc3102/tez-ui/src/main/webapp/tests/unit/controllers/dag/index-test.js ---------------------------------------------------------------------- diff --git a/tez-ui/src/main/webapp/tests/unit/controllers/dag/index-test.js b/tez-ui/src/main/webapp/tests/unit/controllers/dag/index-test.js index 176b9e7..9917e03 100644 --- a/tez-ui/src/main/webapp/tests/unit/controllers/dag/index-test.js +++ b/tez-ui/src/main/webapp/tests/unit/controllers/dag/index-test.js @@ -32,4 +32,5 @@ test('Basic creation test', function(assert) { }); assert.ok(controller); + assert.equal(controller.logLinkDefinition.target, "_blank"); });
