Repository: tez Updated Branches: refs/heads/master a39f02e40 -> 314dfc79b
TEZ-3962. Configuration decode leaks an Inflater object (Eric Wohlstadter via jlowe) Project: http://git-wip-us.apache.org/repos/asf/tez/repo Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/314dfc79 Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/314dfc79 Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/314dfc79 Branch: refs/heads/master Commit: 314dfc79b4b3f528b680b4fee73ad0dca3a3a19b Parents: a39f02e Author: Jason Lowe <[email protected]> Authored: Thu Jun 28 16:13:02 2018 -0500 Committer: Jason Lowe <[email protected]> Committed: Thu Jun 28 16:13:02 2018 -0500 ---------------------------------------------------------------------- .../src/main/java/org/apache/tez/common/TezUtils.java | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tez/blob/314dfc79/tez-api/src/main/java/org/apache/tez/common/TezUtils.java ---------------------------------------------------------------------- diff --git a/tez-api/src/main/java/org/apache/tez/common/TezUtils.java b/tez-api/src/main/java/org/apache/tez/common/TezUtils.java index efd4502..aed9e0f 100644 --- a/tez-api/src/main/java/org/apache/tez/common/TezUtils.java +++ b/tez-api/src/main/java/org/apache/tez/common/TezUtils.java @@ -112,11 +112,12 @@ public class TezUtils { Preconditions.checkNotNull(byteString, "ByteString must be specified"); // SnappyInputStream uncompressIs = new // SnappyInputStream(byteString.newInput()); - InflaterInputStream uncompressIs = new InflaterInputStream(byteString.newInput()); - DAGProtos.ConfigurationProto confProto = DAGProtos.ConfigurationProto.parseFrom(uncompressIs); - Configuration conf = new Configuration(false); - readConfFromPB(confProto, conf); - return conf; + try(InflaterInputStream uncompressIs = new InflaterInputStream(byteString.newInput())) { + DAGProtos.ConfigurationProto confProto = DAGProtos.ConfigurationProto.parseFrom(uncompressIs); + Configuration conf = new Configuration(false); + readConfFromPB(confProto, conf); + return conf; + } } /**
