This is an automated email from the ASF dual-hosted git repository.

jeagles pushed a commit to branch branch-0.9
in repository https://gitbox.apache.org/repos/asf/tez.git


The following commit(s) were added to refs/heads/branch-0.9 by this push:
     new 9a6e64d  TEZ-4265. Tez UI doesn't show Load Counters button if any of 
the Dags have them
9a6e64d is described below

commit 9a6e64de472e1d38537869e2ca85382bfc812f6b
Author: Eric Badger <[email protected]>
AuthorDate: Fri Jan 22 16:48:15 2021 -0600

    TEZ-4265. Tez UI doesn't show Load Counters button if any of the Dags have 
them
    
    Signed-off-by: Jonathan Eagles <[email protected]>
    (cherry picked from commit f481d3899dceda668b74d993cd37f72da3009127)
---
 tez-ui/src/main/webapp/app/components/home-table-controls.js          | 4 ++--
 .../webapp/tests/integration/components/home-table-controls-test.js   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tez-ui/src/main/webapp/app/components/home-table-controls.js 
b/tez-ui/src/main/webapp/app/components/home-table-controls.js
index 70c3863..0804ede 100644
--- a/tez-ui/src/main/webapp/app/components/home-table-controls.js
+++ b/tez-ui/src/main/webapp/app/components/home-table-controls.js
@@ -25,8 +25,8 @@ export default Ember.Component.extend({
     var processedRows = this.get("dataProcessor.processedRows"),
         countersLoaded = true;
     if(processedRows) {
-      countersLoaded = processedRows.some(function (row) {
-        return Object.keys(row.get("counterGroupsHash")).length !== 0;
+      countersLoaded = !processedRows.any(function (row) {
+        return Object.keys(row.get("counterGroupsHash")).length === 0;
       });
     }
     return countersLoaded;
diff --git 
a/tez-ui/src/main/webapp/tests/integration/components/home-table-controls-test.js
 
b/tez-ui/src/main/webapp/tests/integration/components/home-table-controls-test.js
index ccce2db..c35c339 100644
--- 
a/tez-ui/src/main/webapp/tests/integration/components/home-table-controls-test.js
+++ 
b/tez-ui/src/main/webapp/tests/integration/components/home-table-controls-test.js
@@ -66,7 +66,7 @@ test('countersLoaded test', function(assert) {
     })]
   });
   this.render(hbs`{{home-table-controls dataProcessor=dataProcessor}}`);
-  assert.equal(this.$().find("button").attr("class").split(" 
").indexOf("no-visible"), 2);
+  assert.equal(this.$().find("button").attr("class").split(" 
").indexOf("no-visible"), -1);
 
   this.set("dataProcessor", {
     processedRows: [Ember.Object.create({

Reply via email to