Updated Branches: refs/heads/master d34bea0c0 -> 7b96b2249
THRIFT-1805 Thrift should not swallow ALL exceptions Patch: Diwaker Gupta Project: http://git-wip-us.apache.org/repos/asf/thrift/repo Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/7b96b224 Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/7b96b224 Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/7b96b224 Branch: refs/heads/master Commit: 7b96b2249a43ae75b48e0aba7e8beffc67b32d93 Parents: d34bea0 Author: Roger Meier <[email protected]> Authored: Wed Jan 23 20:18:58 2013 +0100 Committer: Roger Meier <[email protected]> Committed: Wed Jan 23 20:18:58 2013 +0100 ---------------------------------------------------------------------- .../src/org/apache/thrift/ProcessFunction.java | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/thrift/blob/7b96b224/lib/java/src/org/apache/thrift/ProcessFunction.java ---------------------------------------------------------------------- diff --git a/lib/java/src/org/apache/thrift/ProcessFunction.java b/lib/java/src/org/apache/thrift/ProcessFunction.java index 2ba3527..19c8f14 100644 --- a/lib/java/src/org/apache/thrift/ProcessFunction.java +++ b/lib/java/src/org/apache/thrift/ProcessFunction.java @@ -37,8 +37,8 @@ public abstract class ProcessFunction<I, T extends TBase> { try { result = getResult(iface, args); - } catch(Throwable th) { - LOGGER.error("Internal error processing " + getMethodName(), th); + } catch(TException tex) { + LOGGER.error("Internal error processing " + getMethodName(), tex); TApplicationException x = new TApplicationException(TApplicationException.INTERNAL_ERROR, "Internal error processing " + getMethodName()); oprot.writeMessageBegin(new TMessage(getMethodName(), TMessageType.EXCEPTION, seqid));
