Revert "THRIFT-1907 Compiling namespace and sub-namespace directives for unrecognized generators should only be a warning"
This reverts commit d28d4d578470233e384ae6012d0ecfa5a8f3deba. Project: http://git-wip-us.apache.org/repos/asf/thrift/repo Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/f837f301 Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/f837f301 Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/f837f301 Branch: refs/heads/master Commit: f837f301819d1f1661a185d1e64566e170933357 Parents: d28d4d5 Author: Henrique Mendonça <[email protected]> Authored: Thu May 16 21:25:18 2013 +0200 Committer: Henrique Mendonça <[email protected]> Committed: Thu May 16 21:25:18 2013 +0200 ---------------------------------------------------------------------- compiler/cpp/src/parse/t_program.h | 3 +-- test/ThriftTest.thrift | 8 +------- 2 files changed, 2 insertions(+), 9 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/thrift/blob/f837f301/compiler/cpp/src/parse/t_program.h ---------------------------------------------------------------------- diff --git a/compiler/cpp/src/parse/t_program.h b/compiler/cpp/src/parse/t_program.h index dfd9d43..12fcf0e 100644 --- a/compiler/cpp/src/parse/t_program.h +++ b/compiler/cpp/src/parse/t_program.h @@ -188,8 +188,7 @@ class t_program : public t_doc { if (sub_index != std::string::npos) { std::string sub_namespace = language.substr(sub_index+1); if ( ! it->second->is_valid_namespace(sub_namespace)) { - std::string warning = base_language + " generator does not accept '" + sub_namespace + "' as sub-namespace!"; - pwarning(1, warning.c_str()); + throw base_language + " generator does not accept '" + sub_namespace + "' as sub-namespace!"; } } } http://git-wip-us.apache.org/repos/asf/thrift/blob/f837f301/test/ThriftTest.thrift ---------------------------------------------------------------------- diff --git a/test/ThriftTest.thrift b/test/ThriftTest.thrift index be000b6..2be53fa 100644 --- a/test/ThriftTest.thrift +++ b/test/ThriftTest.thrift @@ -35,12 +35,6 @@ namespace go ThriftTest namespace php ThriftTest namespace delphi Thrift.Test namespace cocoa ThriftTest - -// Presence of namespaces and sub-namespaces for which there is -// no generator should compile with warnings only -namespace noexist ThriftTest -namespace cpp.noexist ThriftTest - namespace * thrift.test /** @@ -374,4 +368,4 @@ struct StructA { struct StructB { 1: optional StructA aa; 2: required StructA ab; -} +} \ No newline at end of file
