Updated Branches:
  refs/heads/master cc25c52de -> 6ce16d95a

THRIFT-2049 Go compiler doesn't build on native Windows

Patch: Ben Craig & Jens Geyer


Project: http://git-wip-us.apache.org/repos/asf/thrift/repo
Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/6ce16d95
Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/6ce16d95
Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/6ce16d95

Branch: refs/heads/master
Commit: 6ce16d95a4e543f5c930d5518d5f1db1263b0333
Parents: cc25c52
Author: Jens Geyer <[email protected]>
Authored: Fri Jun 21 00:03:50 2013 +0200
Committer: Jens Geyer <[email protected]>
Committed: Fri Jun 21 00:04:45 2013 +0200

----------------------------------------------------------------------
 compiler/cpp/src/generate/t_go_generator.cc | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/thrift/blob/6ce16d95/compiler/cpp/src/generate/t_go_generator.cc
----------------------------------------------------------------------
diff --git a/compiler/cpp/src/generate/t_go_generator.cc 
b/compiler/cpp/src/generate/t_go_generator.cc
index 9abd230..020bea4 100644
--- a/compiler/cpp/src/generate/t_go_generator.cc
+++ b/compiler/cpp/src/generate/t_go_generator.cc
@@ -476,11 +476,7 @@ void t_go_generator::init_generator()
 
     for (sv_iter = services.begin(); sv_iter != services.end(); ++sv_iter) {
         string service_dir = package_dir_ + "/" + 
underscore((*sv_iter)->get_name()) + "-remote";
-#ifdef MINGW
-        mkdir(service_dir.c_str());
-#else
-        mkdir(service_dir.c_str(), 0755);
-#endif
+        MKDIR(service_dir.c_str());
     }
 
     // Print header
@@ -2131,6 +2127,7 @@ void t_go_generator::generate_service_remote(t_service* 
tservice)
     // Close service file
     f_remote.close();
     format_go_output(f_remote_name);
+#ifndef _MSC_VER
     // Make file executable, love that bitwise OR action
     chmod(f_remote_name.c_str(),
           S_IRUSR
@@ -2143,6 +2140,7 @@ void t_go_generator::generate_service_remote(t_service* 
tservice)
           | S_IXOTH
 #endif
          );
+#endif
 }
 
 /**

Reply via email to