Repository: thrift Updated Branches: refs/heads/master 779b9ac2e -> 3290336e3
THRIFT-2495 JavaScript/Node string constants lack proper escaping Client: JS Patch: Jens Geyer Project: http://git-wip-us.apache.org/repos/asf/thrift/repo Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/3290336e Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/3290336e Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/3290336e Branch: refs/heads/master Commit: 3290336e33a257d77d731aa8f4c86af84bd8f9ad Parents: 779b9ac Author: Jens Geyer <[email protected]> Authored: Sun Apr 27 18:29:50 2014 +0200 Committer: Jens Geyer <[email protected]> Committed: Sun Apr 27 18:30:40 2014 +0200 ---------------------------------------------------------------------- compiler/cpp/src/generate/t_js_generator.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/thrift/blob/3290336e/compiler/cpp/src/generate/t_js_generator.cc ---------------------------------------------------------------------- diff --git a/compiler/cpp/src/generate/t_js_generator.cc b/compiler/cpp/src/generate/t_js_generator.cc index 5788749..be0c331 100644 --- a/compiler/cpp/src/generate/t_js_generator.cc +++ b/compiler/cpp/src/generate/t_js_generator.cc @@ -396,7 +396,7 @@ string t_js_generator::render_const_value(t_type* type, t_const_value* value) { t_base_type::t_base tbase = ((t_base_type*)type)->get_base(); switch (tbase) { case t_base_type::TYPE_STRING: - out << "'" << value->get_string() << "'"; + out << "'" << get_escaped_string(value) << "'"; break; case t_base_type::TYPE_BOOL: out << (value->get_integer() > 0 ? "true" : "false");
