Repository: thrift Updated Branches: refs/heads/master 79c9911b8 -> 1a8e048bd
THRIFT-3120 Minor spelling errors and an outdated URL Client: C++ Patch: Calvin Sun <[email protected]> This closes #471 Project: http://git-wip-us.apache.org/repos/asf/thrift/repo Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/1a8e048b Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/1a8e048b Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/1a8e048b Branch: refs/heads/master Commit: 1a8e048bd05b8506ab06200282e2ba516927786e Parents: 79c9911 Author: Jens Geyer <[email protected]> Authored: Thu Apr 30 20:29:20 2015 +0200 Committer: Jens Geyer <[email protected]> Committed: Thu Apr 30 20:37:20 2015 +0200 ---------------------------------------------------------------------- lib/cpp/src/thrift/concurrency/BoostThreadFactory.h | 3 +-- lib/cpp/src/thrift/concurrency/Thread.h | 2 +- lib/cpp/src/thrift/concurrency/ThreadManager.h | 4 ++-- lib/cpp/src/thrift/protocol/TProtocol.h | 3 +-- 4 files changed, 5 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/thrift/blob/1a8e048b/lib/cpp/src/thrift/concurrency/BoostThreadFactory.h ---------------------------------------------------------------------- diff --git a/lib/cpp/src/thrift/concurrency/BoostThreadFactory.h b/lib/cpp/src/thrift/concurrency/BoostThreadFactory.h index fc06e56..e6d1a56 100644 --- a/lib/cpp/src/thrift/concurrency/BoostThreadFactory.h +++ b/lib/cpp/src/thrift/concurrency/BoostThreadFactory.h @@ -43,8 +43,7 @@ public: * to both is given up. * * Threads are created with the specified boost policy, priority, stack-size. A detachable thread - *is not - * joinable. + * is not joinable. * * By default threads are not joinable. */ http://git-wip-us.apache.org/repos/asf/thrift/blob/1a8e048b/lib/cpp/src/thrift/concurrency/Thread.h ---------------------------------------------------------------------- diff --git a/lib/cpp/src/thrift/concurrency/Thread.h b/lib/cpp/src/thrift/concurrency/Thread.h index 1d9153f..f5eb3a8 100644 --- a/lib/cpp/src/thrift/concurrency/Thread.h +++ b/lib/cpp/src/thrift/concurrency/Thread.h @@ -55,7 +55,7 @@ public: /** * Gets the thread object that is hosting this runnable object - can return - * an empty boost::shared pointer if no references remain on thet thread object + * an empty boost::shared pointer if no references remain on that thread object */ virtual boost::shared_ptr<Thread> thread() { return thread_.lock(); } http://git-wip-us.apache.org/repos/asf/thrift/blob/1a8e048b/lib/cpp/src/thrift/concurrency/ThreadManager.h ---------------------------------------------------------------------- diff --git a/lib/cpp/src/thrift/concurrency/ThreadManager.h b/lib/cpp/src/thrift/concurrency/ThreadManager.h index 7bb71d1..2112845 100644 --- a/lib/cpp/src/thrift/concurrency/ThreadManager.h +++ b/lib/cpp/src/thrift/concurrency/ThreadManager.h @@ -41,14 +41,14 @@ class ThreadManager; * * This class manages a pool of threads. It uses a ThreadFactory to create * threads. It never actually creates or destroys worker threads, rather - * It maintains statistics on number of idle threads, number of active threads, + * it maintains statistics on number of idle threads, number of active threads, * task backlog, and average wait and service times and informs the PoolPolicy * object bound to instances of this manager of interesting transitions. It is * then up the PoolPolicy object to decide if the thread pool size needs to be * adjusted and call this object addWorker and removeWorker methods to make * changes. * - * This design allows different policy implementations to used this code to + * This design allows different policy implementations to use this code to * handle basic worker thread management and worker task execution and focus on * policy issues. The simplest policy, StaticPolicy, does nothing other than * create a fixed number of threads. http://git-wip-us.apache.org/repos/asf/thrift/blob/1a8e048b/lib/cpp/src/thrift/protocol/TProtocol.h ---------------------------------------------------------------------- diff --git a/lib/cpp/src/thrift/protocol/TProtocol.h b/lib/cpp/src/thrift/protocol/TProtocol.h index 5d44043..f220d5c 100644 --- a/lib/cpp/src/thrift/protocol/TProtocol.h +++ b/lib/cpp/src/thrift/protocol/TProtocol.h @@ -39,8 +39,7 @@ // The most obvious implementation is to just cast a pointer, // but that doesn't work. // For a pretty in-depth explanation of the problem, see -// http://www.cellperformance.com/mike_acton/2006/06/ (...) -// understanding_strict_aliasing.html +// http://cellperformance.beyond3d.com/articles/2006/06/understanding-strict-aliasing.html template <typename To, typename From> static inline To bitwise_cast(From from) { BOOST_STATIC_ASSERT(sizeof(From) == sizeof(To));
