THRIFT-3124: some signed/unsigned warnings removed from compiler Client: all Patch: Konrad Grochowski
Project: http://git-wip-us.apache.org/repos/asf/thrift/repo Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/de7cf5df Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/de7cf5df Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/de7cf5df Branch: refs/heads/master Commit: de7cf5df9244c3e1a45c0150f1f77e730ba20e1c Parents: 13699f8 Author: Konrad Grochowski <[email protected]> Authored: Mon May 4 11:24:20 2015 +0200 Committer: Konrad Grochowski <[email protected]> Committed: Mon May 4 11:24:47 2015 +0200 ---------------------------------------------------------------------- compiler/cpp/src/generate/t_go_generator.cc | 6 +++--- compiler/cpp/src/generate/t_html_generator.cc | 2 +- compiler/cpp/src/generate/t_py_generator.cc | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/thrift/blob/de7cf5df/compiler/cpp/src/generate/t_go_generator.cc ---------------------------------------------------------------------- diff --git a/compiler/cpp/src/generate/t_go_generator.cc b/compiler/cpp/src/generate/t_go_generator.cc index 8c219ad..c949225 100644 --- a/compiler/cpp/src/generate/t_go_generator.cc +++ b/compiler/cpp/src/generate/t_go_generator.cc @@ -2060,7 +2060,7 @@ void t_go_generator::generate_service_remote(t_service* tservice) { std::vector<t_field*>::size_type num_args = args.size(); bool first = true; - for (int i = 0; i < num_args; ++i) { + for (std::vector<t_field*>::size_type i = 0; i < num_args; ++i) { if (first) { first = false; } else { @@ -2195,7 +2195,7 @@ void t_go_generator::generate_service_remote(t_service* tservice) { f_remote << indent() << " flag.Usage()" << endl; f_remote << indent() << "}" << endl; - for (int i = 0; i < num_args; ++i) { + for (std::vector<t_field*>::size_type i = 0; i < num_args; ++i) { int flagArg = i + 1; t_type* the_type(args[i]->get_type()); t_type* the_type2(get_true_type(the_type)); @@ -2359,7 +2359,7 @@ void t_go_generator::generate_service_remote(t_service* tservice) { f_remote << indent() << "fmt.Print(client." << pubName << "("; bool argFirst = true; - for (int i = 0; i < num_args; ++i) { + for (std::vector<t_field*>::size_type i = 0; i < num_args; ++i) { if (argFirst) { argFirst = false; } else { http://git-wip-us.apache.org/repos/asf/thrift/blob/de7cf5df/compiler/cpp/src/generate/t_html_generator.cc ---------------------------------------------------------------------- diff --git a/compiler/cpp/src/generate/t_html_generator.cc b/compiler/cpp/src/generate/t_html_generator.cc index 6333d71..91f3d0a 100644 --- a/compiler/cpp/src/generate/t_html_generator.cc +++ b/compiler/cpp/src/generate/t_html_generator.cc @@ -1039,7 +1039,7 @@ void t_html_generator::generate_service(t_service* tservice) { for (; arg_iter != args.end(); arg_iter++) { if (!first) { f_out_ << "," << endl; - for (int i = 0; i < offset; ++i) { + for (std::string::size_type i = 0; i < offset; ++i) { f_out_ << " "; } } http://git-wip-us.apache.org/repos/asf/thrift/blob/de7cf5df/compiler/cpp/src/generate/t_py_generator.cc ---------------------------------------------------------------------- diff --git a/compiler/cpp/src/generate/t_py_generator.cc b/compiler/cpp/src/generate/t_py_generator.cc index 22658a1..08a3536 100644 --- a/compiler/cpp/src/generate/t_py_generator.cc +++ b/compiler/cpp/src/generate/t_py_generator.cc @@ -1415,7 +1415,7 @@ void t_py_generator::generate_service_remote(t_service* tservice) { vector<t_field*>::const_iterator a_iter; std::vector<t_field*>::size_type num_args = args.size(); bool first = true; - for (int i = 0; i < num_args; ++i) { + for (std::vector<t_field*>::size_type i = 0; i < num_args; ++i) { if (first) { first = false; } else { @@ -1472,7 +1472,7 @@ void t_py_generator::generate_service_remote(t_service* tservice) { << " if len(args) != " << num_args << ":" << endl << " print('" << (*f_iter)->get_name() << " requires " << num_args << " args')" << endl << " sys.exit(1)" << endl << " pp.pprint(client." << (*f_iter)->get_name() << "("; - for (int i = 0; i < num_args; ++i) { + for (std::vector<t_field*>::size_type i = 0; i < num_args; ++i) { if (args[i]->get_type()->is_string()) { f_remote << "args[" << i << "],"; } else {
