THRIFT-3468 Dart TSocketTransport onError handler is too restrictive Client: Dart Patch: Mark Erickson
This closes #728 Project: http://git-wip-us.apache.org/repos/asf/thrift/repo Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/dd89dce8 Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/dd89dce8 Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/dd89dce8 Branch: refs/heads/master Commit: dd89dce84b73ca671c8e0b3cf597f1888e2a75dc Parents: bc3829e Author: Mark Erickson <[email protected]> Authored: Wed Dec 2 09:53:27 2015 -0600 Committer: Jens Geyer <[email protected]> Committed: Wed Dec 2 21:50:11 2015 +0100 ---------------------------------------------------------------------- .gitignore | 1 + lib/dart/lib/src/transport/t_socket_transport.dart | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/thrift/blob/dd89dce8/.gitignore ---------------------------------------------------------------------- diff --git a/.gitignore b/.gitignore index 040c71e..bcbbd6f 100644 --- a/.gitignore +++ b/.gitignore @@ -146,6 +146,7 @@ erl_crash.dump /lib/d/test/serialization_benchmark /lib/d/test/transport_test /lib/d/unittest/ +/lib/dart/coverage /lib/dart/**/.packages /lib/dart/**/packages /lib/dart/**/.pub/ http://git-wip-us.apache.org/repos/asf/thrift/blob/dd89dce8/lib/dart/lib/src/transport/t_socket_transport.dart ---------------------------------------------------------------------- diff --git a/lib/dart/lib/src/transport/t_socket_transport.dart b/lib/dart/lib/src/transport/t_socket_transport.dart index ad7e48e..d23e6ab 100644 --- a/lib/dart/lib/src/transport/t_socket_transport.dart +++ b/lib/dart/lib/src/transport/t_socket_transport.dart @@ -28,7 +28,7 @@ part of thrift; /// /// Adapted from the JS WebSocket transport. abstract class TSocketTransport extends TBufferedTransport { - final Logger log = new Logger('thrift.TSocketTransport'); + final Logger logger = new Logger('thrift.TSocketTransport'); final TSocket socket; @@ -38,7 +38,7 @@ abstract class TSocketTransport extends TBufferedTransport { throw new ArgumentError.notNull('socket'); } - socket.onError.listen((String e) => log.warning(e)); + socket.onError.listen((e) => logger.warning(e)); socket.onMessage.listen(handleIncomingMessage); }
