Repository: thrift Updated Branches: refs/heads/master 34bd992bc -> 2d6060d88
THRIFT-4046 fix PlatformSocket.h for mingw64/msys2 and provide instructions for building with cmake under that toolchain Client: cmake Patch: James E. King, III <[email protected]> This closes #1171 Project: http://git-wip-us.apache.org/repos/asf/thrift/repo Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/2d6060d8 Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/2d6060d8 Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/2d6060d8 Branch: refs/heads/master Commit: 2d6060d882069ed3e3d6302aa63ea7eb4bb155ad Parents: 34bd992 Author: James E. King, III <[email protected]> Authored: Tue Jan 31 16:17:03 2017 -0500 Committer: James E. King, III <[email protected]> Committed: Tue Jan 31 16:17:53 2017 -0500 ---------------------------------------------------------------------- build/cmake/README-MSYS2.md | 63 ++++++++++++++++++++++ lib/cpp/src/thrift/transport/PlatformSocket.h | 3 ++ 2 files changed, 66 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/thrift/blob/2d6060d8/build/cmake/README-MSYS2.md ---------------------------------------------------------------------- diff --git a/build/cmake/README-MSYS2.md b/build/cmake/README-MSYS2.md new file mode 100644 index 0000000..06c0205 --- /dev/null +++ b/build/cmake/README-MSYS2.md @@ -0,0 +1,63 @@ +<!--- +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +--> + +# Building thrift on Windows (MinGW64/MSYS2) + +Thrift uses cmake to make it easier to build the project on multiple platforms, however to build a fully functional and production ready thrift on Windows requires a number of third party libraries to be obtained. Once third party libraries are ready, the right combination of options must be passed to cmake in order to generate the correct environment. + +> Note: libevent and libevent-devel do not work with this toolchain as they do not properly detect mingw64 and expect some headers to exist that do not, so the non-blocking server is not currently built into this solution. + +## MSYS2 + +Download and fully upgrade msys2 following the instructions at: + + https://msys2.github.io/ + +Install the necessary toolchain items for C++: + + $ pacman -S bison flex openssl openssl-devel \ + mingw-w64-x86_64-boost mingw-w64-x86_64-cmake \ + mingw-w64-x86_64-toolchain zlib zlib-devel + +Update your msys2 bash path to include /mingw64/bin by adding a line to your ~/.bash_profiles using this command: + + echo "export PATH=/mingw64/bin:\$PATH" >> ~/.bash_profile + +After that, close your shell and open a new one. + +Use cmake to create a MinGW makefile, out of tree (assumes you are in the top level of the thrift source tree): + + mkdir ../thrift-build + cd ../thrift-build + cmake -G"MinGW Makefiles" -DCMAKE_MAKE_PROGRAM=/mingw64/bin/mingw32-make \ + -DCMAKE_C_COMPILER=x86_64-w64-mingw32-gcc.exe \ + -DCMAKE_CXX_COMPILER=x86_64-w64-mingw32-g++.exe \ + -DWITH_BOOSTTHREADS=ON -DWITH_LIBEVENT=OFF \ + -DWITH_SHARED_LIB=OFF -DWITH_STATIC_LIB=ON \ + -DWITH_JAVA=OFF -DWITH_PYTHON=OFF -DWITH_PERL=OFF \ + ../thrift + +Build thrift (inside thrift-build): + + cmake --build . + +Run the tests (inside thrift-build): + + ctest + +> If you run into issues, check Apache Jira THRIFT-4046 for patches relating to MinGW64/MSYS2 builds. + +## Tested With + +msys2 64-bit 2016-10-26 distribution \ No newline at end of file http://git-wip-us.apache.org/repos/asf/thrift/blob/2d6060d8/lib/cpp/src/thrift/transport/PlatformSocket.h ---------------------------------------------------------------------- diff --git a/lib/cpp/src/thrift/transport/PlatformSocket.h b/lib/cpp/src/thrift/transport/PlatformSocket.h index e7addd6..b8974ba 100644 --- a/lib/cpp/src/thrift/transport/PlatformSocket.h +++ b/lib/cpp/src/thrift/transport/PlatformSocket.h @@ -78,6 +78,9 @@ # define THRIFT_POLLOUT POLLOUT # endif //WINVER # define THRIFT_SHUT_RDWR SD_BOTH +# if _WIN32_WINNT < 0x0600 +# define AI_ADDRCONFIG 0 +# endif #else //not _WIN32 # include <errno.h> # define THRIFT_GET_SOCKET_ERROR errno
