This is an automated email from the ASF dual-hosted git repository.
jking pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/thrift.git
The following commit(s) were added to refs/heads/master by this push:
new 8a6d9f4 Update pull request template to be more helpful
8a6d9f4 is described below
Author: James E. King, III <jk...@apache.org>
AuthorDate: Mon Apr 9 08:11:38 2018 -0400
Update pull request template to be more helpful
pull_request_template.md | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/pull_request_template.md b/pull_request_template.md
index 2a18207..0b6965b 100644
@@ -1,17 +1,19 @@
-#### Instructions for Apache Thrift Pull Requests ####
+Some helpful tips for a successful Apache Thrift PR:
-* All code changes require an Apache Jira THRIFT Issue
-* Pull requests should contain a single commit per issue, or we will ask you
to squash it.
-* The pull request title must begin with the Jira THRIFT ticket identifier,
+* Did you test your changes locally or using CI in your fork?
+* Is the Apache Jira THRIFT ticket identifier in the PR title?
+* Is the Apache Jira THRIFT ticket identifier in the commit message?
+* Did you squash your changes to a single commit?
+* Are these changes backwards compatible? (please say so in PR description)
+* Do you need to update the language-specific README?
+Example ideal pull request title:
THRIFT-9999: an example pull request title
-* Commit messages must follow this pattern for code changes (deviations will
not be merged):
+Example ideal commit message:
THRIFT-9999: [summary of fix, one line if possible]
Client: [language(s) affected, comma separated, use lib/ directory
-* Remove these instructions from any pull request description.
For more information about committing, see CONTRIBUTING.md
To stop receiving notification emails like this one, please contact