[thrift] branch master updated: THRIFT-4851: Remove All Calls To printStackTrace Client: Java Patch: Beluga Behr

[jensg]

This is an automated email from the ASF dual-hosted git repository.

jensg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/thrift.git


The following commit(s) were added to refs/heads/master by this push:
     new cc13de4  THRIFT-4851: Remove All Calls To printStackTrace Client: Java 
Patch: Beluga Behr <dam6...@gmail.com>
cc13de4 is described below

commit cc13de4f87bda658d138b4f9b47f55202be4ac51
Author: Beluga Behr <dam6...@gmail.com>
AuthorDate: Wed Apr 17 11:00:53 2019 -0400

    THRIFT-4851: Remove All Calls To printStackTrace
    Client: Java
    Patch: Beluga Behr <dam6...@gmail.com>
    
    This closes #1783
---
 lib/java/src/org/apache/thrift/server/TNonblockingServer.java  |  1 -
 .../org/apache/thrift/transport/TNonblockingServerSocket.java  |  2 +-
 .../src/org/apache/thrift/transport/TSSLTransportFactory.java  | 10 ++++++++--
 3 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/lib/java/src/org/apache/thrift/server/TNonblockingServer.java 
b/lib/java/src/org/apache/thrift/server/TNonblockingServer.java
index fe0365a..2358c63 100644
--- a/lib/java/src/org/apache/thrift/server/TNonblockingServer.java
+++ b/lib/java/src/org/apache/thrift/server/TNonblockingServer.java
@@ -239,7 +239,6 @@ public class TNonblockingServer extends 
AbstractNonblockingServer {
       } catch (TTransportException tte) {
         // something went wrong accepting.
         LOGGER.warn("Exception trying to accept!", tte);
-        tte.printStackTrace();
         if (clientKey != null) cleanupSelectionKey(clientKey);
         if (client != null) client.close();
       }
diff --git 
a/lib/java/src/org/apache/thrift/transport/TNonblockingServerSocket.java 
b/lib/java/src/org/apache/thrift/transport/TNonblockingServerSocket.java
index ef82ac2..df37cb0 100644
--- a/lib/java/src/org/apache/thrift/transport/TNonblockingServerSocket.java
+++ b/lib/java/src/org/apache/thrift/transport/TNonblockingServerSocket.java
@@ -103,7 +103,7 @@ public class TNonblockingServerSocket extends 
TNonblockingServerTransport {
       try {
         serverSocket_.setSoTimeout(0);
       } catch (SocketException sx) {
-        sx.printStackTrace();
+        LOGGER.error("Socket exception while setting socket timeout", sx);
       }
     }
   }
diff --git a/lib/java/src/org/apache/thrift/transport/TSSLTransportFactory.java 
b/lib/java/src/org/apache/thrift/transport/TSSLTransportFactory.java
index 2232a31..73dfaaf 100644
--- a/lib/java/src/org/apache/thrift/transport/TSSLTransportFactory.java
+++ b/lib/java/src/org/apache/thrift/transport/TSSLTransportFactory.java
@@ -37,11 +37,17 @@ import javax.net.ssl.SSLSocket;
 import javax.net.ssl.SSLSocketFactory;
 import javax.net.ssl.TrustManagerFactory;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 /**
  *  A Factory for providing and setting up Client and Server SSL wrapped
  *  TSocket and TServerSocket
  */
 public class TSSLTransportFactory {
+  
+  private static final Logger LOGGER =
+      LoggerFactory.getLogger(TSSLTransportFactory.class);
 
   /**
    * Get a SSL wrapped TServerSocket bound to the specified port. In this
@@ -225,14 +231,14 @@ public class TSSLTransportFactory {
         try {
           in.close();
         } catch (IOException e) {
-          e.printStackTrace();
+          LOGGER.warn("Unable to close stream", e);
         }
       }
       if (is != null) {
         try {
           is.close();
         } catch (IOException e) {
-          e.printStackTrace();
+          LOGGER.warn("Unable to close stream", e);
         }
       }
     }