[thrift] branch master updated: THRIFT-4942 Set PHP struct generated field values as private with getters and setters Client: php Patch: Das Dedipyaman

[jensg]

This is an automated email from the ASF dual-hosted git repository.

jensg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/thrift.git


The following commit(s) were added to refs/heads/master by this push:
     new 6fd830d  THRIFT-4942 Set PHP struct generated field values as private 
with getters and setters Client: php Patch: Das Dedipyaman
6fd830d is described below

commit 6fd830d69024435290ff0e92936b89ebc9603678
Author: Dedipyaman Das <30053071+2dsh...@users.noreply.github.com>
AuthorDate: Sun Sep 27 02:29:23 2020 +0530

    THRIFT-4942 Set PHP struct generated field values as private with getters 
and setters
    Client: php
    Patch: Das Dedipyaman
    
    This closes #2245
    
    Update field access for getters_setters flag. FFields are private if 
getters_setters are set, otherwise, public.
---
 compiler/cpp/src/thrift/generate/t_php_generator.cc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/compiler/cpp/src/thrift/generate/t_php_generator.cc 
b/compiler/cpp/src/thrift/generate/t_php_generator.cc
index 10dc570..96d5fbe 100644
--- a/compiler/cpp/src/thrift/generate/t_php_generator.cc
+++ b/compiler/cpp/src/thrift/generate/t_php_generator.cc
@@ -939,7 +939,8 @@ void 
t_php_generator::generate_php_struct_definition(ostream& out,
       dval = render_const_value((*m_iter)->get_type(), (*m_iter)->get_value());
     }
     generate_php_doc(out, *m_iter);
-    indent(out) << "public $" << (*m_iter)->get_name() << " = " << dval << ";" 
<< endl;
+    string access = (getters_setters_) ? "private" : "public";
+    indent(out) << access << " $" << (*m_iter)->get_name() << " = " << dval << 
";" << endl;
   }
 
   out << endl;