This is an automated email from the ASF dual-hosted git repository.

zeshuai007 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/thrift.git


The following commit(s) were added to refs/heads/master by this push:
     new 22671db  Add an Automatic-Module-Name entry
22671db is described below

commit 22671db01f5c349f2fa54b393581cb4d61bdd895
Author: Mark Raynsford <[email protected]>
AuthorDate: Wed Oct 21 20:01:40 2020 +0000

    Add an Automatic-Module-Name entry
    
    This adds an Automatic-Module-Name entry to the Thrift jar manifest
    in order to provide Thrift with a stable module name when used in a
    JPMS modular context. The name chosen here is "org.apache.thrift",
    which matches the symbolic name used for OSGi.
    
    See: http://branchandbound.net/blog/java/2017/12/automatic-module-name/
---
 lib/java/gradle/sourceConfiguration.gradle | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/java/gradle/sourceConfiguration.gradle 
b/lib/java/gradle/sourceConfiguration.gradle
index 3bd432a..07c2a7f 100644
--- a/lib/java/gradle/sourceConfiguration.gradle
+++ b/lib/java/gradle/sourceConfiguration.gradle
@@ -71,6 +71,7 @@ jar {
     manifest {
         attributes([
             "Implementation-Version": "${project.version}",
+            "Automatic-Module-Name": "${project.group}",
             "Bundle-ManifestVersion": "2",
             "Bundle-SymbolicName": "${project.group}",
             "Bundle-Name": "Apache Thrift",

Reply via email to