[thrift] branch 0.14.0 updated: THRIFT-5350 char is unsigned on non-x86 arches, use signed char to avoid compiler warning about always true comparisons Patch: Orion Poplawski

[jensg]

This is an automated email from the ASF dual-hosted git repository.

jensg pushed a commit to branch 0.14.0
in repository https://gitbox.apache.org/repos/asf/thrift.git


The following commit(s) were added to refs/heads/0.14.0 by this push:
     new 011eb22  THRIFT-5350 char is unsigned on non-x86 arches, use signed 
char to avoid compiler warning about always true comparisons Patch: Orion 
Poplawski
011eb22 is described below

commit 011eb22e32eea4a3220dcea6fd63f608e682ba2c
Author: Orion Poplawski <or...@nwra.com>
AuthorDate: Wed Feb 17 07:52:49 2021 -0700

    THRIFT-5350 char is unsigned on non-x86 arches, use signed char to avoid 
compiler warning about always true comparisons
    Patch: Orion Poplawski
    
    This closes #2331
---
 compiler/cpp/src/thrift/generate/t_delphi_generator.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/compiler/cpp/src/thrift/generate/t_delphi_generator.cc 
b/compiler/cpp/src/thrift/generate/t_delphi_generator.cc
index d3ad76a..eac46a6 100644
--- a/compiler/cpp/src/thrift/generate/t_delphi_generator.cc
+++ b/compiler/cpp/src/thrift/generate/t_delphi_generator.cc
@@ -1062,7 +1062,7 @@ std::string 
t_delphi_generator::make_pascal_string_literal(std::string value) {
   }
 
   result << "'";
-  for (char const &c: value) {
+  for (signed char const c: value) {
     if( (c >= 0) && (c < 32)) {  // convert ctrl chars, but leave UTF-8 alone
       result << "#" << (int)c;  
     } else if (c == '\'') {