[thrift] branch master updated: THRIFT-5476 Deprecate Common Lisp support Client: cl Patch: Jens Geyer

[jensg]

This is an automated email from the ASF dual-hosted git repository.

jensg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/thrift.git


The following commit(s) were added to refs/heads/master by this push:
     new 591575a  THRIFT-5476 Deprecate Common Lisp support Client: cl Patch: 
Jens Geyer
591575a is described below

commit 591575a8a891717b002abecef57f99830a8c6752
Author: Jens Geyer <je...@apache.org>
AuthorDate: Fri Oct 29 21:49:12 2021 +0200

    THRIFT-5476 Deprecate Common Lisp support
    Client: cl
    Patch: Jens Geyer
---
 compiler/cpp/src/thrift/generate/t_generator.cc | 5 ++++-
 lib/cl/Makefile.am                              | 6 ++++--
 test/cl/Makefile.am                             | 6 ++++--
 tutorial/cl/Makefile.am                         | 5 +++--
 4 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/compiler/cpp/src/thrift/generate/t_generator.cc 
b/compiler/cpp/src/thrift/generate/t_generator.cc
index f26690b..52ca011 100644
--- a/compiler/cpp/src/thrift/generate/t_generator.cc
+++ b/compiler/cpp/src/thrift/generate/t_generator.cc
@@ -237,7 +237,10 @@ t_generator* 
t_generator_registry::get_generator(t_program* program,
   if ((language == "csharp") || (language == "netcore")) {
     failure("The '%s' target is no longer available. Use 'netstd' instead.", 
language.c_str());
   }
-
+  if (language == "cl") {
+    pwarning(1, "The '%s' target is deprecated and will be removed in future 
versions.", language.c_str());
+  }
+  
   if (iter == the_map.end()) {
     return nullptr;
   }
diff --git a/lib/cl/Makefile.am b/lib/cl/Makefile.am
index 34b3886..a2b2b96 100644
--- a/lib/cl/Makefile.am
+++ b/lib/cl/Makefile.am
@@ -23,10 +23,12 @@ all-local:
        bash ensure-externals.sh
 
 run-tests: test/make-test-binary.lisp
-       $(SBCL) --script test/make-test-binary.lisp
+       @echo 'cl tests broken, commented out due to deprecation'
+       ## $(SBCL) --script test/make-test-binary.lisp
 
 check-local: run-tests
-       ./run-tests
+       @echo 'cl tests broken, commented out due to deprecation'
+       ## ./run-tests
 
 clean-local:
        $(RM) run-tests quicklisp.lisp backport-update.zip
diff --git a/test/cl/Makefile.am b/test/cl/Makefile.am
index b5e72bc..7cba7cd 100755
--- a/test/cl/Makefile.am
+++ b/test/cl/Makefile.am
@@ -23,10 +23,12 @@ stubs: ../ThriftTest.thrift
        $(THRIFT) --gen cl ../ThriftTest.thrift
 
 TestServer: make-test-server.lisp
-       $(SBCL) --script make-test-server.lisp
+       @echo 'cl broken, commented out due to deprecation'
+       ## $(SBCL) --script make-test-server.lisp
 
 TestClient: make-test-client.lisp
-       $(SBCL) --script make-test-client.lisp
+       @echo 'cl broken, commented out due to deprecation'
+       ## $(SBCL) --script make-test-client.lisp
 
 precross: stubs TestServer TestClient
 
diff --git a/tutorial/cl/Makefile.am b/tutorial/cl/Makefile.am
index 70c5e07..77e995c 100755
--- a/tutorial/cl/Makefile.am
+++ b/tutorial/cl/Makefile.am
@@ -36,8 +36,9 @@ ALL_FILE_PREREQS = \
 # because their dependencies are shared, parallel jobs can
 # end up overwriting or corrupting the compiled files
 all-local: gen-cl setup-local-lisp-env $(ALL_FILE_PREREQS)
-       $(SBCL) --script make-tutorial-server.lisp
-       $(SBCL) --script make-tutorial-client.lisp
+       @echo 'cl broken, commented out due to deprecation'
+       ## $(SBCL) --script make-tutorial-server.lisp
+       ## $(SBCL) --script make-tutorial-client.lisp
 
 tutorialserver: all
        ./TutorialServer