This is an automated email from the ASF dual-hosted git repository.
kpumuk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/thrift.git
The following commit(s) were added to refs/heads/master by this push:
new 18d9ff647 Enable RuboCop Style/LineEndConcatenation (#3732)
18d9ff647 is described below
commit 18d9ff6475af7978e58aeb8f3e00480e9640dc6e
Author: Dmytro Shteflyuk <[email protected]>
AuthorDate: Thu Aug 20 10:01:42 2026 -0400
Enable RuboCop Style/LineEndConcatenation (#3732)
Client: rb
Co-authored-by: OpenAI Codex (GPT-5.6) <[email protected]>
---
lib/rb/.rubocop.yml | 3 ++
test/rb/integration/TestClient.rb | 58 +++++++++++++++++++--------------------
2 files changed, 32 insertions(+), 29 deletions(-)
diff --git a/lib/rb/.rubocop.yml b/lib/rb/.rubocop.yml
index 3c0dbb096..fed658d68 100644
--- a/lib/rb/.rubocop.yml
+++ b/lib/rb/.rubocop.yml
@@ -312,6 +312,9 @@ Style/HashSyntax:
Enabled: true
EnforcedShorthandSyntax: either
+Style/LineEndConcatenation:
+ Enabled: true
+
Style/MethodDefParentheses:
Enabled: true
diff --git a/test/rb/integration/TestClient.rb
b/test/rb/integration/TestClient.rb
index 169481cea..819b25a63 100755
--- a/test/rb/integration/TestClient.rb
+++ b/test/rb/integration/TestClient.rb
@@ -159,36 +159,36 @@ class SimpleClientTest < Test::Unit::TestCase
def test_string
p "test_string"
escaped_string =
- 'quote: \" backslash:' +
- ' forwardslash-escaped: \/ ' +
- ' backspace: \b formfeed: \f newline: \n return: \r tab: ' +
- ' now-all-of-them-together: "\\\/\b\n\r\t' +
- ' now-a-bunch-of-junk: !@#$%&()(&%$#{}{}<><><' +
+ 'quote: \" backslash:' \
+ ' forwardslash-escaped: \/ ' \
+ ' backspace: \b formfeed: \f newline: \n return: \r tab: ' \
+ ' now-all-of-them-together: "\\\/\b\n\r\t' \
+ ' now-a-bunch-of-junk: !@#$%&()(&%$#{}{}<><><' \
' char-to-test-json-parsing: ]] \"]] \\" }}}{ [[[ '
- unicode_string = "Afrikaans, Alemannisch, Aragonés, العربية, مصرى, " +
- "Asturianu, Aymar aru, Azərbaycan, Башҡорт, Boarisch, Žemaitėška, " +
- "Беларуская, Беларуская (тарашкевіца), Български, Bamanankan, " +
- "বাংলা, Brezhoneg, Bosanski, Català, Mìng-dĕ̤ng-ngṳ̄, Нохчийн, " +
- "Cebuano, ᏣᎳᎩ, Česky, Словѣ́ньскъ / ⰔⰎⰑⰂⰡⰐⰠⰔⰍⰟ, Чӑвашла, Cymraeg, " +
- "Dansk, Zazaki, ދިވެހިބަސް, Ελληνικά, Emiliàn e rumagnòl, English, " +
- "Esperanto, Español, Eesti, Euskara, فارسی, Suomi, Võro, Føroyskt, " +
- "Français, Arpetan, Furlan, Frysk, Gaeilge, 贛語, Gàidhlig, Galego, " +
- "Avañe'ẽ, ગુજરાતી, Gaelg, עברית, हिन्दी, Fiji Hindi, Hrvatski, " +
- "Kreyòl ayisyen, Magyar, Հայերեն, Interlingua, Bahasa Indonesia, " +
- "Ilokano, Ido, Íslenska, Italiano, 日本語, Lojban, Basa Jawa, " +
- "ქართული, Kongo, Kalaallisut, ಕನ್ನಡ, 한국어, Къарачай-Малкъар, " +
- "Ripoarisch, Kurdî, Коми, Kernewek, Кыргызча, Latina, Ladino, " +
- "Lëtzebuergesch, Limburgs, Lingála, ລາວ, Lietuvių, Latviešu, Basa " +
- "Banyumasan, Malagasy, Македонски, മലയാളം, मराठी, مازِرونی, Bahasa " +
- "Melayu, Nnapulitano, Nedersaksisch, नेपाल भाषा, Nederlands, " +
- "Norsk (nynorsk), Norsk (bokmål), Nouormand, Diné bizaad, " +
- "Occitan, Иронау, Papiamentu, Deitsch, Polski, پنجابی, پښتو, " +
- "Norfuk / Pitkern, Português, Runa Simi, Rumantsch, Romani, Română, " +
- "Русский, Саха тыла, Sardu, Sicilianu, Scots, Sámegiella, Simple " +
- "English, Slovenčina, Slovenščina, Српски / Srpski, Seeltersk, " +
- "Svenska, Kiswahili, தமிழ், తెలుగు, Тоҷикӣ, ไทย, Türkmençe, Tagalog, " +
- "Türkçe, Татарча/Tatarça, Українська, اردو, Tiếng Việt, Volapük, " +
- "Walon, Winaray, 吴语, isiXhosa, ייִדיש, Yorùbá, Zeêuws, 中文, " +
+ unicode_string = "Afrikaans, Alemannisch, Aragonés, العربية, مصرى, " \
+ "Asturianu, Aymar aru, Azərbaycan, Башҡорт, Boarisch, Žemaitėška, " \
+ "Беларуская, Беларуская (тарашкевіца), Български, Bamanankan, " \
+ "বাংলা, Brezhoneg, Bosanski, Català, Mìng-dĕ̤ng-ngṳ̄, Нохчийн, " \
+ "Cebuano, ᏣᎳᎩ, Česky, Словѣ́ньскъ / ⰔⰎⰑⰂⰡⰐⰠⰔⰍⰟ, Чӑвашла, Cymraeg, " \
+ "Dansk, Zazaki, ދިވެހިބަސް, Ελληνικά, Emiliàn e rumagnòl, English, " \
+ "Esperanto, Español, Eesti, Euskara, فارسی, Suomi, Võro, Føroyskt, " \
+ "Français, Arpetan, Furlan, Frysk, Gaeilge, 贛語, Gàidhlig, Galego, " \
+ "Avañe'ẽ, ગુજરાતી, Gaelg, עברית, हिन्दी, Fiji Hindi, Hrvatski, " \
+ "Kreyòl ayisyen, Magyar, Հայերեն, Interlingua, Bahasa Indonesia, " \
+ "Ilokano, Ido, Íslenska, Italiano, 日本語, Lojban, Basa Jawa, " \
+ "ქართული, Kongo, Kalaallisut, ಕನ್ನಡ, 한국어, Къарачай-Малкъар, " \
+ "Ripoarisch, Kurdî, Коми, Kernewek, Кыргызча, Latina, Ladino, " \
+ "Lëtzebuergesch, Limburgs, Lingála, ລາວ, Lietuvių, Latviešu, Basa " \
+ "Banyumasan, Malagasy, Македонски, മലയാളം, मराठी, مازِرونی, Bahasa " \
+ "Melayu, Nnapulitano, Nedersaksisch, नेपाल भाषा, Nederlands, " \
+ "Norsk (nynorsk), Norsk (bokmål), Nouormand, Diné bizaad, " \
+ "Occitan, Иронау, Papiamentu, Deitsch, Polski, پنجابی, پښتو, " \
+ "Norfuk / Pitkern, Português, Runa Simi, Rumantsch, Romani, Română, " \
+ "Русский, Саха тыла, Sardu, Sicilianu, Scots, Sámegiella, Simple " \
+ "English, Slovenčina, Slovenščina, Српски / Srpski, Seeltersk, " \
+ "Svenska, Kiswahili, தமிழ், తెలుగు, Тоҷикӣ, ไทย, Türkmençe, Tagalog, " \
+ "Türkçe, Татарча/Tatarça, Українська, اردو, Tiếng Việt, Volapük, " \
+ "Walon, Winaray, 吴语, isiXhosa, ייִדיש, Yorùbá, Zeêuws, 中文, " \
"Bân-lâm-gú, 粵語"
[escaped_string, unicode_string].each do |test_string|
